-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added implementation of feature_permutation #91
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #91 +/- ##
==========================================
- Coverage 97.41% 95.31% -2.1%
==========================================
Files 7 7
Lines 541 555 +14
Branches 69 71 +2
==========================================
+ Hits 527 529 +2
- Misses 7 19 +12
Partials 7 7
Continue to review full report at Codecov.
|
This implementation can be multi-threaded. I can give it at shot at a later point. Leaving this link for later: |
As this is similar to ELI5's PermutationImportance I suggest the following features that it has:
|
metric=None): | ||
""" | ||
Calculates feature importance by randomly permuting features and comparing result to baseline | ||
:param y: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't y training/test target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, changed the implementation without updating docs - still have some work to do on this feature 😄
I'll have a look at their implementation - see if there's some cleverness we can use |
Working on issue #59