UUID byte order #34
Merged
UUID byte order #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte ordering in MongoDB has a messy history. The old binary subtype 0x03 had implementation defined byte ordering. Technically drivers are meant to expose configuration to deal with this. Subtype 0x04 implements byte order in accordance with RFC 4122, from most to least significant byte, e.g., canonical network byte order.
See https://github.com/mongodb/specifications/blob/master/source/bson-binary-uuid/uuid.md for details.
Updating major version since this is a potentially data breaking change.