Move over to N-API from NAN

[anandsuresh]

No description provided.

[NickNaso]

Hi @anandsuresh it seems good to me. It's a good starting point to next release

[anandsuresh]

@NickNaso What would be a good next step? Should we make a PR against the NAPI repo linking this branch to the list of NAPI modules?

[NickNaso]

Hi @anandsuresh I linked the issue BAPI Support with an issue on the abi-stable-node repo https://github.com/nodejs/abi-stable-node/issues/246 . In this issue we report our porting activities and if you want fell free to report your experience with N-API.
For the sse4_crc32 module we can publish a tagged version of the module as reported here in this guide https://nodejs.org/en/docs/guides/publishing-napi-modules/ this means that people can start using the N-API version of the module today if they install like reported below:
npm install sse4_crc32@n-api
After some time we can consider to switch to N-API version.
if you will publish the module please ping me so I will provide to spread the news of the porting.

[zbjornson]

@anandsuresh it looks like this is based on an old commit, based on the diff. Are you still planning to move forward with this? There's some code cleanup (around the native build, quite a bit of code that can be removed) that I'd love to contribute, but don't want to mess up your N-API work. On the other hand, you might have an easier time converting to N-API with my proposed cleanup.

[anandsuresh]

Sure. I haven't had a lot of time to focus on this. If you have any code to contribute, that would be awesome.

…

On Fri, Oct 26, 2018, 1:19 PM Zach Bjornson ***@***.*** wrote: @anandsuresh <https://github.com/anandsuresh> it looks like this is based on an old commit, based on the diff. Are you still planning to move forward with this? There's some code cleanup (around the native build, quite a bit of code that can be removed) that I'd love to contribute, but don't want to mess up your N-API work. On the other hand, you might have an easier time converting to N-API with my proposed cleanup. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-tuVjiiDJbtbXFXA5AftOyzXFLogXiks5uo25qgaJpZM4UUaa3> .

[ivan]

I have updated this PR over at https://github.com/ludios/sse4_crc32/commits/master and I am testing it, feel free to take my commits.

[stephenplusplus]

@anandsuresh Hello! Any thoughts on how we should proceed with this migration?

[stephenplusplus]

@ivan would you be willing to send your changes as a PR here? Whatever we can do to make it easier for @anandsuresh to merge and release 🙏

[anandsuresh]

Whoops. Sorry guys. Been a little busy lately. I should have some down-time this week to look this over and get it merged. Let me know if there is anything else that I can help with. Thanks Anand

…

On Tue, Sep 17, 2019 at 6:28 AM Stephen ***@***.***> wrote: @ivan <https://github.com/ivan> would you be willing to send your changes as a PR here? Whatever we can do to make it easier for @anandsuresh <https://github.com/anandsuresh> to merge and release 🙏 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#71?email_source=notifications&email_token=AAH23OIJYRKZNGYZRX7R463QKDLOJA5CNFSM4FCRU232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD64QUSA#issuecomment-532220488>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH23OKS4FB3EXJ3RYLSVMLQKDLOJANCNFSM4FCRU23Q> .

[ivan]

@anandsuresh FYI I think there's a UAF here that I fixed with ludios@d39bdd7

[anandsuresh]

Thanks @NickNaso for getting this started, and to @ivan for the fixes. With v6, the package is now available on NPM as well as GitHub Package Registry! Apologies for delays at my end.