Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add environments to repository model #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpascoe
Copy link

@jpascoe jpascoe commented Nov 14, 2024

Description

I needed to be able to set the environments for a repository in our corporate JFrog Artifactory. This is a simple addition to the model.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has it been tested ?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • I created a new repository specifying the environment and checked the environment was set in Artifactory
  • I updated an existing repository specifying the environment and checked the environment was set in Artifactory

Checklist:

  • My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • All commits have a correct title
  • Readme has been updated
  • Quality tests are green (see Codacy)
  • Automated tests are green (see pipeline)

@jpascoe
Copy link
Author

jpascoe commented Nov 14, 2024

I've created issue 205

@@ -141,6 +141,7 @@ class SimpleRepository(BaseModel):
description: Optional[str] = None
url: str
packageType: str
environments: List[str] = ['DEV']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add the environment here. The Get repositories result does not contain environment (See Artifactory API)

Comment on lines +24 to +25
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add support to Python 3.13, you will need to add it to the test matrix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants