fix(PeriphDrivers): Fix OWM Presence Detect Bit and GPIO Alternate Functions, Use VDDIOH by Default #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32650
ozersa
force-pushed
the
fix/OWM_Driver_Issues
branch
2 times, most recently
from
a325705 to
fd15437
Compare
- MAX32655/ MAX32650/ MAX78000/ MAX78002 presence detect bit is 7 not 5 - MAX32655 OWM GPIO alternate function 2 not 1 - MAX32655/MAX32690 OWM GPIO mapping B pins defined - Unneeded code which set voltage source deleted from drivers - Voltage source selected as VDDIOH to provide 3.3V. - SVD files updated to indicated correct presence bit Signed-off-by: Sadik Ozer <[email protected]>
ozersa
force-pushed
the
fix/OWM_Driver_Issues
branch
from
fd15437 to
34b8d55
Compare
|
/generate-register-files |
Jacob-Scheiffler
approved these changes
Nov 29, 2023
|
Something seems wrong with the SVD workflow. @sihyung-maxim tagging you so you can look at this when you're back. Will merge this now, the header files look correct to me |
Jake-Carter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Test output on MAX32655 with MAX31825 target
ROM ID read succeeded.
Checklist Before Requesting Review
PS: It will be nice to update init function to it take map parameters to select related gpio mapping but I am not sure whether API should be changed now or not. Changing API will break existing customer build system but i am not sure whether is there any one customer to use OWM API or not.
See MAX32570 OWM init function