fix(SDHC): Fix SDHC Driver Clock Divider for MAX78002 #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
changed the title
lorne-maxim
approved these changes
Dec 20, 2023
sihyung-maxim
approved these changes
Dec 20, 2023
Examples/MAX78002/SDHC_Raw/main.c
Outdated
Comment on lines
299
to
305
| // if (SystemCoreClock > 96000000) { | ||
| // printf("SD clock ratio (at card) 4:1\n"); | ||
| // MXC_SDHC_Set_Clock_Config(1); | ||
| // } else { | ||
| // printf("SD clock ratio (at card) 2:1\n"); | ||
| // MXC_SDHC_Set_Clock_Config(0); | ||
| // } |
There was a problem hiding this comment.
Are we leaving these in just in case?
There was a problem hiding this comment.
Thanks, good catch. I was, but they can be removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Closes #797 and implements #791 for the MAX780002
Ports the MAX78002 SDHC_FAT example using the new CLI for #770
Also reduces the default SDHC_CLK_FREQ to 30Mhz, since MAX78002 initializes with the 60Mhz ISO by default.
Checklist Before Requesting Review