fix(Build): Load MSYS2 Before Native Windows Make #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
requested review from
lorne-maxim,
Jacob-Scheiffler and
sihyung-maxim
Jake-Carter
changed the title
Jake-Carter
changed the title
lorne-maxim
approved these changes
Oct 6, 2023
sihyung-maxim
approved these changes
Oct 6, 2023
|
Regenerating project files now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing shows the legacy "split" Makefiles for RISC-V projects are hard-coded for MSYS2/unix style paths. Ex: Hello_World-riscv
Installing the native Windows Make broke these projects, because I loaded the native version before the MSYS2 version.
Additionally, colorized output breaks if native Windows Make is used, but MSYS2
/usr/binis on the PATH.This PR makes the MSYS2 take precedence over the native version so we don't break anything. Switching to the native version will be an "opt-in" feature for this release.
See also https://github.com/Analog-Devices-MSDK/Packages/pull/4, which does this for
setenv.bat.Checklist Before Requesting Review