fix(ThirdParty,Examples): Add missing dependencies to LVGL makefiles #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorne-maxim
requested review from
Jake-Carter,
sihyung-maxim and
Jacob-Scheiffler
Jacob-Scheiffler
approved these changes
Oct 6, 2023
Jake-Carter
suggested changes
Oct 6, 2023
|
I thought it was strange that the other makefiles weren't using IPATH. I just stuck with the style used by the others, though. What do you think? Should we rework all the makefiles in LVGL? |
|
Eh... at this point that's probably a better cleanup task for a later date. If they all use this convention this'll work |
Jake-Carter
approved these changes
Oct 6, 2023
|
That's what I was hoping you'd say! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing statements needed for all files in the Libraries/LVGL/lvgl/src/extra directories.
Disable Flash ECC in the MAX32672 Flash example. It uses 32-bit writes which will not work when ECC is enabled.