feat(BLE, Examples): Add coded PHY long range demo on MAX32665 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yc-adi
requested review from
EdwinFairchild,
lorne-maxim,
victor-levi-maxim,
EricB-ADI and
AbbyWolf-ADI
github-actions
bot
added
MAX32665
|
/clang-format-run |
EricB-ADI
requested changes
Sep 21, 2023
|
/clang-format-run |
EricB-ADI
approved these changes
Sep 22, 2023
|
For the current customer application, the master only scans the for the EXT ADV. But for the general long range applications, 4 dBm TX power definitely will be helpful. I will change it from 0 dBm to 4 dBm.
Thanks!
From: Victor Levi ***@***.***>
Sent: Friday, September 22, 2023 1:53 PM
To: Analog-Devices-MSDK/msdk ***@***.***>
Cc: Cai, Ying ***@***.***>; Author ***@***.***>
Subject: Re: [Analog-Devices-MSDK/msdk] feat(BLE, Examples): Add coded PHY long range demo on MAX32665 (PR #740)
[External]
@victor-levi-maxim commented on this pull request.
________________________________
In Examples/MAX32665/BLE_LR_Central/main.c<https://urldefense.com/v3/__https:/github.com/Analog-Devices-MSDK/msdk/pull/740*discussion_r1334722826__;Iw!!A3Ni8CS0y2Y!9UDSYeD_WqTKEJQNWTczwtGqaiAIIPsJVc8QdIm3LSuWEv-0UW4nbnDl5W1nEFNPXo8t7YyD1das3i07Qf27cX-j$>:
+
+#include "pal_bb.h"
+#include "pal_cfg.h"
+#include "pal_timer.h"
+#include "pal_sys.h"
+
+#include "lr_central_api.h"
+#include "app_ui.h"
+
+/**************************************************************************************************
+ Macros
+**************************************************************************************************/
+
+/*! \brief UART TX buffer size */
+#define PLATFORM_UART_TERMINAL_BUFFER_SIZE 2048U
+#define DEFAULT_TX_POWER 0 /* dBm */
Default slave TX power is 4dBm, should default master TX power be 4 dBm as well for larger connection range?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/Analog-Devices-MSDK/msdk/pull/740*pullrequestreview-1640490987__;Iw!!A3Ni8CS0y2Y!9UDSYeD_WqTKEJQNWTczwtGqaiAIIPsJVc8QdIm3LSuWEv-0UW4nbnDl5W1nEFNPXo8t7YyD1das3i07QXI0R7CI$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A2NWXE2UPZOCQZSDFIIH72DX3XNA7ANCNFSM6AAAAAA5BYXBGY__;!!A3Ni8CS0y2Y!9UDSYeD_WqTKEJQNWTczwtGqaiAIIPsJVc8QdIm3LSuWEv-0UW4nbnDl5W1nEFNPXo8t7YyD1das3i07QfsU_4jw$>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
victor-levi-maxim
approved these changes
Sep 23, 2023
| 'a', | ||
| 'n', | ||
| 'g' | ||
| }; |
There was a problem hiding this comment.
Should device name be spelled as "LongRange"?
|
One last thing. Is there a reason the adverting name is LongRang and not LongRange? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Examples/MAX32665/BLE_LR_Peripheral and BLE_LR_Central to demonstrate coded PHY (S=8) for BLE long range mode.