-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SDHC)!: Fix SDHC Formats Card Size Incorrectly, Update FatFS to R0.15, Add SDXC and exFAT Support #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32650
Related to the MAX32650 (ME10)
MAX32665
Related to the MAX32665 (ME14)
MAX78000
Related to the MAX78000 (AI85)
MAX78002
Related to the MAX78002 (AI87)
labels
Aug 25, 2023
Jake-Carter
force-pushed
the
dev/ff15
branch
from
September 19, 2023 19:03
1b6bd48
to
308052f
Compare
github-actions
bot
removed
MAX32570
Related to the MAX32570 (ME13)
MAX32650
Related to the MAX32650 (ME10)
MAX78002
Related to the MAX78002 (AI87)
labels
Sep 19, 2023
github-actions
bot
added
MAX32570
Related to the MAX32570 (ME13)
MAX32650
Related to the MAX32650 (ME10)
MAX78002
Related to the MAX78002 (AI87)
labels
Sep 20, 2023
Fix getSize() and change Maxim to Analog on printf statements.
fix(SDHC): The patch repairs getSize() in main.c of SDHC_FAT to properly calculate SD Card disk capacity
- Merge remote-tracking branch 'remotes/upstream/main' into dev/ff15
4 tasks
EricB-ADI
pushed a commit
that referenced
this pull request
Nov 21, 2023
…0.15, Add SDXC and exFAT Support (#720) Co-authored-by: Brian Hindman <[email protected]> Co-authored-by: Jake-Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix
The SDHC_FAT example would format cards incorrectly. For a 32GB card, the library would format it with a card size of 1.8GB. This was caused by an integer overflow error in the native SDHC library implementation (fixed in 9771dcc)
FatFS Version Upgrade
I aded support for R0.15 of the FatFS library. This has some potentially relevant bug fixes (see change notes).
The default version is still R0.13, but will be updated to R0.15 next release. Users can upgrade now by setting the
FATFS_VERSION
build configuration variable toff15
.FatFS R0.15 changed the input parameters for
f_mkfs
to acccept a format struct.Users upgrading from R0.13/R0.14 -> R0.15 can make the following change to the f_mkfs function.
Alternatively, users can set the new
FATFS_VERSION
build configuration variable toff13
orff14
to keep using the old versions for their project.SDXC and exFAT Support
The ff15 configuration now enables SDXC support out of the box. This enables larger card sizes.
exFAT support requires LFN (Long File-Name Support), which requires unicode support. This increases the library size significantly. I'm open to suggestions on how to deal with it. Should we provide a mechanism for easily toggling SDXC support? Or just rely on the user to edit
ffconf.h
as needed?Testing
I tested the SDHC_FAT example on the MAX32666FTHR, MAX32666EVKIT, and MAX78002EVKIT to validate the native SDHC implementation.
Checklist Before Requesting Review