-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Examples,PeriphDrivers)!: Add SPI v2 Target Transaction functions #662
Conversation
For consistency, should I rename the SPI_MasterSlave example to SPI_ControllerTarget? |
/clang-format-run |
Also, I just copy-pasted the porting guide/README from the SPI example to the SPI_MasterSlave. I am not sure if this is good enough, so please review it and let me know if it's enough for a user to follow. |
I renamed it. |
Another idea. Should I leave the SPI_MasterSlave example using the SPI v2 Master/Slave functions to show the functional changes between the previous SPI API and SPI v2? |
/clang-format-run |
…heck for M/S mode
…into dev/spi_target
/clang-format-run |
…_DRV TS Control Scheme
/clang-format-run |
The SW_DRV TS control scheme made the driver too complex while still attempting to be backward compatible with SPI v1. It has lost the ease of usability at that point, so I elected to entirely remove support for that control scheme. |
/clang-format-run |
Ready for review, at the surface everything seems to be working but will do more testing in the morning just to be safe. |
…arget mode functionality (#662) Co-authored-by: sihyung-maxim <[email protected]> Co-authored-by: Jake Carter <[email protected]> Co-authored-by: Jake Carter <[email protected]>
Description
mxc_spi_req_t
struct to old names.Breaking change because there are functional differences with the interrupt handling between the previous SPI API and SPI v2 even if the function prototypes remain the same.
Estimated Timing Averages from function call to start of transaction:
SYSCLK = IPO
SPI v2
Before Excess SPI Instance Check/Asserts Removal:
After Excess SPI Instance Check/Asserts Removal:
SPI v1
Final Overhead Improvement:
Library Size:
Before Excess SPI Instance Check/Asserts Removal
After Excess SPI Instance Check/Asserts Removal
Tests:
Checklist Before Requesting Review