fix(PeriphDrivers, Other): Fix RTC clock source selection #1315
Conversation
github-actions
bot
added
MAX32657
mertvatansever
force-pushed
the
fix-me30-rtc-clock-source
branch
2 times, most recently
from
2c603e4 to
f5ad283
Compare
|
|
||
| switch (clk_src) { | ||
| case MXC_RTC_ERTCO_CLK: | ||
| MXC_GCR->clkctrl |= MXC_F_GCR_CLKCTRL_ERTCO_EN; |
There was a problem hiding this comment.
Please use "MSDK_NO_GPIO_CLK_INIT" macro in here. Also, I think you should use "MXC_SYS_ClockSourceEnable(...)" function to enable clock sources.
There was a problem hiding this comment.
Done, thanks
| return clk_src; | ||
| } | ||
|
|
||
| static inline int WRAP_MXC_RTC_Init(uint32_t sec, uint16_t ssec, uint8_t clock_source) |
There was a problem hiding this comment.
Please update wrapper function names as "Wrap_MXC..." to have same name structure with other wrapper files.
|
|
||
| static inline int WRAP_MXC_RTC_Init(uint32_t sec, uint16_t ssec, uint8_t clock_source) | ||
| { | ||
| int ret; |
There was a problem hiding this comment.
| int ret; | |
| (void)clock_source; | |
| int ret; |
Please add this line for unused parameters.
There was a problem hiding this comment.
I checked Zephyr side now and I think that adding if (clock_source != ADI_MAX32_PRPH_CLK_SRC_ERTCO) { return -1; } line would be nice to handle a bad parameter case.
| MXC_MCR->ctrl &= ~MXC_F_MCR_CTRL_CLKSEL; | ||
| MXC_MCR->ctrl |= MXC_S_MCR_CTRL_CLKSEL_ERTCO; |
There was a problem hiding this comment.
| MXC_MCR->ctrl &= ~MXC_F_MCR_CTRL_CLKSEL; | |
| MXC_MCR->ctrl |= MXC_S_MCR_CTRL_CLKSEL_ERTCO; | |
| MXC_SETFIELD(MXC_MCR->ctrl, MXC_F_MCR_CTRL_CLKSEL, MXC_S_MCR_CTRL_CLKSEL_ERTCO); |
I think you should use MXC_SETFIELD macro here.
| MXC_MCR->ctrl &= ~MXC_F_MCR_CTRL_CLKSEL; | ||
| MXC_MCR->ctrl |= MXC_S_MCR_CTRL_CLKSEL_INRO_DIV4; |
There was a problem hiding this comment.
| MXC_MCR->ctrl &= ~MXC_F_MCR_CTRL_CLKSEL; | |
| MXC_MCR->ctrl |= MXC_S_MCR_CTRL_CLKSEL_INRO_DIV4; | |
| MXC_SETFIELD(MXC_MCR->ctrl, MXC_F_MCR_CTRL_CLKSEL, MXC_S_MCR_CTRL_CLKSEL_INRO_DIV4); |
Same above.
|
|
||
| clk_src = wrap_get_clock_source_instance(clock_source); | ||
|
|
||
| MXC_RTC_SetClockSource(clk_src); |
There was a problem hiding this comment.
Please check "MXC_RTC_SetClockSource" function's return value and then according to its result, call "MXC_RTC_Init" function.
This commit creates an enum for rtc clock sources and adds a function to set clock source for ME30 rtc. Signed-off-by: Mert Vatansever <[email protected]>
This commit adds a wrapper function for MXC_RTC_Init to set clock source for MAX32657. Signed-off-by: Mert Vatansever <[email protected]>
mertvatansever
force-pushed
the
fix-me30-rtc-clock-source
branch
from
f5ad283 to
9db0343
Compare
Description
This PR solves RTC clock source selection problem for ME30. It adds a function to set clock source and creates wrapper function for MXC_RTC_Init to select clock source for ME30.