fix(PeriphDrivers): Fix flash ecc issue for MAX32657 #1300
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertvatansever
requested review from
ttmut,
ozersa,
kevin-gillespie and
sihyung-maxim
mertvatansever
force-pushed
the
fix/flash_ecc_me30
branch
from
17e3449 to
e6105f5
Compare
ttmut
reviewed
Dec 17, 2024
Erasing flash will also erase the ECC bits. These bits are not updated until a flash write. Reading from erased memory will signal a ECC error that is falsely corrected from 0xFF to 0xFD on the 16th byte of each 128-bit line. This commit applies a workaround by setting the 16th byte of each line to 0xFF to handle this issue on max32657. Co-authored-by: Mert Vatansever <[email protected]> Co-authored-by: Kevin Gillespie <[email protected]>
mertvatansever
force-pushed
the
fix/flash_ecc_me30
branch
from
e6105f5 to
94f4406
Compare
Updated the code to set 16th byte to 0xFF if 16th byte is 0xFD and rest of the bytes are 0xFF. |
|
I think this is pretty good for now. There are still some corner cases where we could still be masking an actual ECC error, but I'm also not sure if we'll be able to completely solve the problem. This will only check the range of data that we're reading to make sure it's erased, but we should really check the entire 128 bit line to make sure it's erased. |
kevin-gillespie
approved these changes
Dec 18, 2024
gkhnclkmxm
approved these changes
Dec 18, 2024
ttmut
approved these changes
Dec 18, 2024
MaureenHelm
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Erasing flash will also erase the ECC bits. These bits are not updated until a flash write. Reading from erased memory will signal a ECC error that is falsely corrected from 0xFF to 0xFD on the 16th byte of each 128-bit line.
This PR applies a workaround by setting the 16th byte of each line to 0xFF to handle this issue for max32657.
This is tested with zephyr/tests/drivers/flash/common. The result is indicated below.