fix(BLE): Resolve double increment of memory management in LlInitSetRtCfg #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin-gillespie Nice catch! |
kevin-gillespie
approved these changes
Oct 22, 2024
…levant changes outside of the dats/datc firmware are made, commented ME14 and ME18 checks
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
LlInitSetRtCfg()was first implemented in the mallinfo PRtotalMemUsedwas not utilized.memUsedwas incremented -- instead of overwritten -- when callingLlInitSetLlRtCfg()in addition to the precedingLlInitSetBbRtCfg(), whose memory usage was already accounted for. This is not accurate.Fix
totalMemUsedmemUsedwhen calling eitherLlInitSetLlRtCfg()orLlInitSetBbRtCfg()