feat(Examples): Change Project.md feature for MAX32655, MAX32665, and MAX32690 #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction logic to match full adv name in project.mk
…ction logic to match full adv name in project.mk
github-actions
bot
added
MAX32655
Delete commented previous code
Delete commented previous code
Delete commented previous code
|
Can you add the advertising names update to otas and otac as well? |
Done! I also synced these updates to ME17. Since I don't have the board for ME17, I didn't test it, but I think it should be good. Just copy and paste for these same updates. |
JC-282-AD
changed the title
|
/clang-format-run |
EricB-ADI
reviewed
Jun 24, 2024
|
|
||
|
|
||
| ### CONFIGURE security | ||
| # /*! Authentication and bonding flags */ |
There was a problem hiding this comment.
Delete these commented out configs
| @@ -570,11 +570,14 @@ static void datcScanReport(dmEvt_t *pMsg) | |||
| if (!connect && ((pData = DmFindAdType(DM_ADV_TYPE_LOCAL_NAME, pMsg->scanReport.len, | |||
| pMsg->scanReport.pData)) != NULL)) { | |||
| /* check length and device name */ | |||
| if (pData[DM_AD_LEN_IDX] >= 4 && (pData[DM_AD_DATA_IDX] == 'D') && | |||
| char advName[] = ADV_NAME; | |||
| /*if (pData[DM_AD_LEN_IDX] >= 4 && (pData[DM_AD_DATA_IDX] == 'D') && | |||
There was a problem hiding this comment.
Delete commented out code
There was a problem hiding this comment.
Can you update the variable to be overwritten via the command line when make is called?
Believe this will work.
ADV_NAME?=DATS
PROJ_CFLAGS += -DADV_NAME=\"$(ADV_NAME)\"There was a problem hiding this comment.
Done! My branch diverges somehow. I fix it and hopefully it is clean.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description