Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PeriphDrivers): MAX32657 does not support VSEL #1042

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix(PeriphDrivers): MAX32657 does not support VSEL #1042

merged 1 commit into from
Jun 14, 2024

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Jun 11, 2024

MAX32657: Does not support VSEL selection

image

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@ozersa ozersa requested a review from sihyung-maxim June 11, 2024 10:30
@ozersa ozersa changed the title fix(PeriphDrivers)<!>: MAX32657 does not support VSEL fix(PeriphDrivers): MAX32657 does not support VSEL Jun 11, 2024
@ozersa ozersa requested a review from Jake-Carter June 11, 2024 10:30
@sihyung-maxim
Copy link
Contributor

Should I delete the GPIO_VSSEL register too?

@ozersa
Copy link
Contributor Author

ozersa commented Jun 13, 2024

Should I delete the GPIO_VSSEL register too?

Unless it is mentioned in the UG, it is fine it be there. So just keep it as it is in register map for now.
Thanks

@ozersa ozersa merged commit d97b565 into feat/ME30 Jun 14, 2024
5 of 6 checks passed
@ozersa ozersa deleted the update-max32657-gpio branch June 14, 2024 10:01
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Jun 14, 2024
@actions-user
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1042
0703fa3
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
@actions-user @ozersa
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1042
e0670cc
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
@actions-user @ozersa
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1042
4af9237
ttmut pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 31, 2024
@actions-user @ttmut
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1042
5fc071b
@ttmut ttmut mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

@Jake-Carter Jake-Carter Awaiting requested review from Jake-Carter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozersa @sihyung-maxim