-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CMSIS,Examples,PeriphDrivers)!: Add MAX32665 Dual Core example and Core 1 CMSIS updates #1023
Conversation
…d Core 1 CMSIS updates
… into feat/me14_dualcore
Reverting names because RPU example uses the old core1.h stuff. |
MAX32665 isn't covered by the ble examples workflow. Just ignore the issue. |
just for a note: this PR only adds the example for the MAX32666 EVKIT 514fc1a Shouldn't it be added the the FTHR board as well? |
Have not tested this on the featherboard yet (but it should still work). I'll test on the featherboard and then update its board files for it. |
ARM_DUALCORE=1 | ||
|
||
# Separate directories for Core 0 and Core 1 code. | ||
VPATH += Core0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not be necessary to separate the directories since both cores share the same arch. You could even define main
and main_core1
in the same file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, mainly did this so users can organize their code between the two cores.
Works on FTHR. |
Description
This change only impacts the MAX32665.
This PR organizes the CMSIS files for Core 1 and adds a dual core example. Core1 was not properly set up when the MAX32665 SDK files were initially committed into the MSDK.
There may be some breaking changes because some of the CORE1 files were relocated - I deprecated the old Core1 files that were moved to CMSIS. I also updated some of the function names to be more consistent - any duplicate core0 function name that needs to be supported for core1 will use the
_Core1
suffix.Checklist Before Requesting Review