-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Boards,CMSIS,Examples,PeriphDrivers): Initial commit for MAX32657 #1012
Conversation
This commit enable MAX32657 zephyr support. Signed-off-by: Sadik Ozer <[email protected]>
Signed-off-by: Sadik Ozer <[email protected]>
Co-authored-by: lorne-maxim <[email protected]>
…675 (#1001) Co-authored-by: lorne-maxim <[email protected]> Co-authored-by: Sihyung Woo <[email protected]>
These files are exact copy of MAX32655 Files will be updated in next sections, added here to demonstrate delta clearly on next steps Signed-off-by: Sadik Ozer <[email protected]>
These files are exact copy of MAX32655 Files will be updated in next sections, added here to demonstrate delta clearly on next steps Signed-off-by: Sadik Ozer <[email protected]>
feat(PeriphDrivers): Add max32657 basic files
|
||
#include <core_cm33.h> | ||
#include <arm_cmse.h> | ||
#define IS_SECURE_ENVIRONMENT (defined(__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR shall be merged after below one, to this changes being pushed on hal_adi too. |
Don't mind the failed BLE workflow. It's still in development/testing - last I heard. |
@sihyung-maxim there are some DMA-related build errors if you attempt to build with |
int MXC_UART_RevB_WriteTXFIFODMA(mxc_uart_revb_regs_t *uart, const unsigned char *bytes, | ||
unsigned int len, mxc_uart_dma_complete_cb_t callback, | ||
mxc_dma_config_t config); | ||
int MXC_UART_RevB_WriteTXFIFODMA(mxc_uart_revb_regs_t *uart, mxc_dma_regs_t *dma, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might need to add *dma parameter also to Libraries/PeriphDrivers/Include/MAX32655/uart.h
and other ones that that use revb uart?
Edit* NVM, I updated our hal again to pull in the latest changes to uart_me17.c and it is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to hear!
Dang, I really wanted to avoid using I reverted back the conditional directives. :( |
#define MXC_F_UART_INTEN_TX_THD_POS 6 /**< INTEN_TX_THD Position */ | ||
#define MXC_F_UART_INTEN_TX_THD ((uint32_t)(0x1UL << MXC_F_UART_INTEN_TX_THD_POS)) /**< INTEN_TX_THD Mask */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should still be INTEN_TX_HE
as on the max32655, it is what I see in the spec?
Edit* I guess spec is wrong atm, if this is actually based on me13 UART IP which I guess had TX_THD instead of HE. anyways just noticed because of compile error in zephyr.
Description
This is the initial commit for the MAX32657.
The MAX32657 (ME30) SDK files are still in development and not for official, public use.
Please do not delete the branch after merging this PR.
Checklist Before Requesting Review