2023_R2 backports #2664
Open
2023_R2 backports #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested review from
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
nunojsa
force-pushed
the
staging/2023_R2-backports
branch
from
9550590 to
014cff9
Compare
|
v2:
|
ad7768_scale() is dependent on the st->vref voltage. Hence, simplify the code and get the voltage only during probe (as it should not change at runtime) with devm_regulator_get_enable_read_voltage() [nsa: devm_regulator_get_enable_read_voltage() is not available in 2023_R2, so do it by hand to get the voltage during probe] Fixes: 92cc452 ("iio: adc: ad7768: simplify probe") Co-developed-by: Dragos Bogdan <[email protected]> Signed-off-by: Dragos Bogdan <[email protected]> Signed-off-by: Nuno Sa <[email protected]> (cherry picked from commit 44e7ac1)
Similar to commit 7ebe866 ("iio: adc: adrv9002: fixup tx2 power level") we need to apply the same fixup even in rx2tx2. The reasoning for not doing it at the time was that if the channels are tuned together and have the same SSI delays, it should not be needed. Well... While at it (and as advised by HW folks), we're now doing the fixup for all TX channels. Signed-off-by: Nuno Sa <[email protected]> (cherry picked from commit 13a58d5)
|
Alright, the Fixes hash does not exist in the 2023_R2 branch as the original faulty commit was also cherry-picked in to the release branch. As this is yet another cherry-pick, I don't think it's that important to change the fixes tag so I would say to ignore the CI failure. |
mhennerich
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Two fixes for adrv9002 and ad7768 backported from main.
PR Type
PR Checklist