hwmon: (pmbus/adp1050): Support adp1051 and adp1055 #2629

actorreno · 2024-10-24T08:28:48Z

PR Description

This adds ADP1051 and ADP1055 driver support on existing ADP1050 Driver.
Datasheets ADP1051, ADP1055.
Tested on RPI4 using the following eval boards: ADP1051-EVB, ADP1055-EVB.

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa

Another hint is to run:

git log --oneline drivers/hwmon/pmbus to look for the style used in that dir for commit titles. The most common seems to be (adapted for your case):

hwmon: (pmbus/adp1050): Support adp1051 and adp1055

nunojsa · 2024-10-25T07:45:14Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml

@@ -10,16 +10,35 @@ maintainers:
  - Radu Sabau <[email protected]>

 description: |
-   The ADP1050 is used to monitor system voltages, currents and temperatures.
+   The ADP1050, ADP1051, and ADP1055 are used to monitor system voltages,


This does not scale. Instead say "The ADP1050 and similar devices..."

nunojsa · 2024-10-25T07:45:55Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml

-   The ADP1050 is used to monitor system voltages, currents and temperatures.
+   The ADP1050, ADP1051, and ADP1055 are used to monitor system voltages,
+   currents, power and temperatures.
+
   Through the PMBus interface, the ADP1050 targets isolated power supplies
   and has four individual monitors for input/output voltage, input current
   and temperature.
   Datasheet:
     https://www.analog.com/en/products/adp1050.html


Just add here the links to new datasheets

nunojsa · 2024-10-25T07:47:03Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml


        hwmon@70 {
-            compatible = "adi,adp1050";
+            compatible = "adi,adp1050", "adi,adp1051";


It does not work like this... If you can fallback to some compatible, that needs to be stated in the bindings which is not.

nunojsa · 2024-10-25T07:47:20Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml

            reg = <0x70>;
            vcc-supply = <&vcc>;
+            status = "okay";


remove the status

nunojsa · 2024-10-25T07:47:45Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml

+            compatible = "adi,adp1055";
+            reg = <0x4b>;
+            vcc-supply = <&vcc>;
+            status = "okay";


If it#s only a matter of the address being different, I would not bother in adding another example

nunojsa · 2024-10-25T07:54:22Z

drivers/hwmon/pmbus/adp1050.c

+		   | PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT
+		   | PMBUS_HAVE_IIN | PMBUS_HAVE_TEMP
+		   | PMBUS_HAVE_STATUS_TEMP,
+};


Also unrelated change. I would drop it (or add it in a different patch)

nunojsa · 2024-10-25T07:56:20Z

drivers/hwmon/pmbus/adp1050.c

+	ADP1050,
+	ADP1051,
+	ADP1055,
+};


Drop the id

nunojsa · 2024-10-25T07:56:40Z

drivers/hwmon/pmbus/adp1050.c

-	{ .compatible = "adi,adp1050"},
+	{ .compatible = "adi,adp1050", .data = (void *)ADP1050},
+	{ .compatible = "adi,adp1051", .data = (void *)ADP1051},
+	{ .compatible = "adi,adp1055", .data = (void *)ADP1055},


pass in directly the pmbus_driver_info structs...

nunojsa · 2024-10-25T07:57:29Z

drivers/hwmon/pmbus/adp1050.c

-	{"adp1050", 0},
+	{"adp1050", ADP1050},
+	{"adp1051", ADP1051},
+	{"adp1055", ADP1055},


here you need a cast but there are examples:

https://elixir.bootlin.com/linux/v6.11.5/source/drivers/iio/addac/ad74413r.c#L1530

nunojsa · 2024-10-25T07:58:12Z

drivers/hwmon/pmbus/adp1050.c

-	return pmbus_do_probe(client, &adp1050_info);
+	enum ADP1050_type type;
+
+	type = (enum ADP1050_type)(uintptr_t)device_get_match_data(&client->dev);


Now you can properly do error checking:

info = device_get_match_data(); if (!info) return -ENODEV;

actorreno · 2024-10-28T02:22:23Z

v2

.yaml:

updated description to scale as suggested
removed further descriptions and simply attached datasheet links
reverted back most of the device tree sample
(just a lack of understanding on the yaml file, i thought it was a full device tree)
(no fallback feature intended, but will note just in case)

.rst

dropped the small unrelated change

.c

dropped the unrelated change, astyle adjusts this each run
dopped the ID and directly passed the pmbus structs
used the error checking as suggested

nunojsa

Fell free to send this upstream...

nunojsa · 2024-11-04T15:56:12Z

Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml

+      - enum:
+          - adi,adp1050
+          - adi,adp1051
+          - adi,adp1055


On top of what I've said already, you don't need "items:" in here (as you have things now at least).

nunojsa · 2024-11-04T15:56:57Z

drivers/hwmon/pmbus/adp1050.c

-	return pmbus_do_probe(client, &adp1050_info);
+	struct pmbus_driver_info *info;
+
+	info = (struct pmbus_driver_info *)device_get_match_data(&client->dev);


no need for the cast..

I added the cast just to remove a warning but yes this can be removed to simplify the code further.

edit: removal of the cast started failing some of the checks. is this ok?

nunojsa · 2024-11-04T15:57:23Z

drivers/hwmon/pmbus/adp1050.c

 /* 6.1 probe() function still uses the second struct i2c_device_id argument */
 static int adp1050_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
-	return pmbus_do_probe(client, &adp1050_info);
+	struct pmbus_driver_info *info;


It can be const pmbus_driver_info *info

const pmbus_driver_info *info; returns an error similar to the one below. Will keep the original struct pmbus_driver_info *info;

Obviously a typo from me... const struct pmbus_driver_info *info and then no need for the cast

updated the commit but still fails some checks.

a warning remains it seems

Add dt-bindings for adp1051 and adp1055 pmbus. ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature Signed-off-by: Alexis Torreno <[email protected]>

ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature Signed-off-by: Alexis Torreno <[email protected]>

actorreno requested review from nunojsa, mhennerich, dbogdan, btogorean, chegbeli, buha, amiclaus, rbolboac, danmois, CiprianRegus and machschmitt as code owners October 24, 2024 08:28

actorreno force-pushed the dev/adp1050_support branch 8 times, most recently from ca32f70 to ffc9249 Compare October 25, 2024 02:57

nunojsa reviewed Oct 25, 2024

View reviewed changes

actorreno changed the title ~~Added support for ADP1051 and ADP1055 on existing ADP1050 driver~~ hwmon: (pmbus/adp1050): Support adp1051 and adp1055 Oct 25, 2024

actorreno force-pushed the dev/adp1050_support branch 2 times, most recently from 39943c4 to 9a7485b Compare October 28, 2024 01:59

actorreno requested a review from nunojsa October 31, 2024 01:06

nunojsa reviewed Nov 4, 2024

View reviewed changes

dt-bindings: hwmon: pmbus: adp1051 and adp1055: add bindings.

6282383

Add dt-bindings for adp1051 and adp1055 pmbus. ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature Signed-off-by: Alexis Torreno <[email protected]>

actorreno force-pushed the dev/adp1050_support branch from 9a7485b to 82c4d40 Compare November 5, 2024 06:41

hwmon: pmbus : adp1051 and adp1055: Add driver support

72a535b

ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature Signed-off-by: Alexis Torreno <[email protected]>

actorreno force-pushed the dev/adp1050_support branch from 82c4d40 to 72a535b Compare November 5, 2024 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hwmon: (pmbus/adp1050): Support adp1051 and adp1055 #2629

hwmon: (pmbus/adp1050): Support adp1051 and adp1055 #2629

actorreno commented Oct 24, 2024

nunojsa left a comment

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

nunojsa Oct 25, 2024

actorreno commented Oct 28, 2024

nunojsa left a comment

nunojsa Nov 4, 2024

nunojsa Nov 4, 2024

actorreno Nov 5, 2024 •

edited

Loading

nunojsa Nov 4, 2024

actorreno Nov 5, 2024

nunojsa Nov 5, 2024

actorreno Nov 5, 2024

hwmon: (pmbus/adp1050): Support adp1051 and adp1055 #2629

Are you sure you want to change the base?

hwmon: (pmbus/adp1050): Support adp1051 and adp1055 #2629

Conversation

actorreno commented Oct 24, 2024

PR Description

PR Type

PR Checklist

nunojsa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

actorreno commented Oct 28, 2024

nunojsa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

actorreno Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

actorreno Nov 5, 2024 •

edited

Loading