Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dds 32b phase #864

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Dev dds 32b phase #864

merged 4 commits into from
Sep 26, 2023

Conversation

AndreiGrozav
Copy link
Contributor

@AndreiGrozav AndreiGrozav commented Feb 2, 2022

Add support for DDS phase width grater than 16

The software should read the DDS phase data width register and configure the DDS init and increment registers accordingly, otherwise the obtained DDS output frequency might not be the desired one, in case the DDS phase
width is different than 16(default).

Updated documentation at https://wiki.analog.com/resources/fpga/docs/dds

@AndreiGrozav AndreiGrozav requested a review from acostina February 2, 2022 08:06
@AndreiGrozav AndreiGrozav requested a review from a team March 28, 2022 11:48
@AndreiGrozav AndreiGrozav marked this pull request as ready for review March 28, 2022 11:49
@AndreiGrozav
Copy link
Contributor Author

I have updated this PR.
Rebased to latest master.
Latest documentation at #1171

Copy link
Contributor

@acostina acostina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Do we want to keep the commits separate for the changes ? I understand the commit for cleanup makes sense to be separate, but the other ones if they are separate, may break compilation of the projects

Add support for DDS phase width greather than 16.
The software should read the DDS phase data width register and configure
the DDS init and increment registers accordingly, otherwise the obtained
DDS output frequency will not be the desired one for DDS phase width
different than 16.

DDS_incr = (f_out * 2^(phase_width) * clkratio)/f_if
Allow upto 32 bit phase data width support.
@AndreiGrozav
Copy link
Contributor Author

Squashed functional commits. In order not to break the build.

@AndreiGrozav AndreiGrozav merged commit 9f82455 into master Sep 26, 2023
0 of 2 checks passed
@AndreiGrozav AndreiGrozav deleted the dev_dds_32b_phase branch September 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants