Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad469x : coraz7s: Add axi_iic_ard for evb eeprom #1541

Merged
merged 2 commits into from
Dec 10, 2024
Merged

ad469x : coraz7s: Add axi_iic_ard for evb eeprom #1541

merged 2 commits into from
Dec 10, 2024

Conversation

gastmaier
Copy link
Contributor

PR Description

Use common AXI IIC Controller used to mostly to read the EVB EEPROM.

IIC Changes:
Project       Old          New          IIC Subordinate
ad469x_evb    ps-11, 44a4  ps-11, 4160  M24C02

Fix for missing project from #1517

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@gastmaier
docs: ad469x_evb: Update addr/irq with axi_iic_ard
4e040fc 
Use axi_iic_ard from common design.

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier
projects: ad469x: Use common axi_iic_ard
4ee7347 
The axi_iic_ard is generally used to read the EVB EEPROM with
Arduino uno form factor.

IIC Changes:
Project       Old          New          IIC Subordinate
ad469x_evb    ps-11, 44a4  ps-11, 4160  M24C02

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier gastmaier requested a review from ladace December 10, 2024 12:54
ladace
ladace approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ladace ladace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gastmaier gastmaier marked this pull request as ready for review December 10, 2024 18:51
@gastmaier gastmaier merged commit 2466496 into main Dec 10, 2024
3 of 4 checks passed
@gastmaier gastmaier deleted the ad469x-cora-iic-common branch December 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladace ladace ladace approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastmaier @ladace