axi_dmac: Updated framelock interface pathing in Makefile #1525
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
gastmaier
requested changes
Nov 22, 2024
There was a problem hiding this comment.
0001-Review-axi_dmac-Remove-quiet-to-match-other-intf.patch
Thank you, just remove the quiet to match other library/*/interfaces/Makefile
To match other interfaces/Makefiles. Signed-off-by: Jorge Marques <[email protected]> Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
|
Removed quiet.mk |
gastmaier
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updated interface pathing for axi_dmac.
Problem description: when building the testbenches that rely on the DMAC IP, at the building phase, the interfaces are built for the IP, and then the simulation runs. When running the simulation with make again, the interfaces and the DMAC IP is rebuilt. If nothing changes for the DMAC IP or any of its dependencies, nothing should be rebuilt. When opening the built testbench block design, Vivado gives a warning that it cannot find the interface definition.
PR Type
PR Checklist