Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/ad7134_fmc: Update AD7134 SPIE project. Add FMC pinout. Test software support #1190

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

laurent-19
Copy link
Collaborator

This PR covers the AD7134 SPI Engine project checking and updates. Changes and additions include:

  • Added txt description of all FMC pins used/unused
  • Updated constraint files with FMC pinout location

Hardware test with available software:
AD7134 NO-OS needs updating for new HDL design (PWM trigger for SPIE offload)
NO-OS PR not yet up, waiting for CN0561 PR to see what soft team expects.

Test failed. Initialization of ADC device fails. Debug log:

  • ad713x_init failed due to CHIP_TYPE == 0, it should be CHIP_TYPE == 7
  • first ad713x device (ADC chs 0-3) CHIP_TYPE not initialized
  • second ad713x device (ADC chs 3-7) initialized successfully

Force initialization via the Vitis debugger ==> 0V on ADC channels, conversation fails

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

* Added txt description of all FMC pins used/unused
* Updated constraint files with FMC pinout location

Signed-off-by: laurentiu_popa <[email protected]>
@laurent-19 laurent-19 requested review from StancaPop and a team October 5, 2023 09:44
@laurent-19 laurent-19 changed the title projects/ad7134_fmc: Add FMC pinout description projects/ad7134_fmc: Update AD7134 SPIE project. Add FMC pinout. Test software support Oct 5, 2023
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@laurent-19 laurent-19 merged commit 7ccc505 into master Oct 19, 2023
1 of 2 checks passed
@laurent-19 laurent-19 deleted the update_ad7134_spi_engine branch October 19, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants