Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/ad4134_fmc: Update SPIE project. Add FMC pinout. Test soft support on hardware #1189

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

laurent-19
Copy link
Collaborator

PR Description

This PR covers the AD4134 SPI Engine project checking and updates. Changes and additions include:

  • Added txt description of all FMC pins used/unused
  • Updated constraint files with FMC pinout location

Hardware test with available software:

  • Linux: Test partially successful. A dc signal is obtained. ad4134 Linux driver

  • NO-OS: Tested failed. It cannot communicate with the chip on the evaluation board.
    AD413X NO-OS project Debugger log: dev_init fails. dev_id should be 4, but it is always 0. Changes in NO-OS must be made in order to recognize the chip.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@laurent-19 laurent-19 requested a review from a team October 5, 2023 08:51
* Added txt description of all FMC pins used/unused
* Updated constraint files with FMC pinout location

Signed-off-by: laurentiu_popa <[email protected]>
@laurent-19 laurent-19 force-pushed the update_ad4134_spi_engine branch from 2d81881 to 0d61129 Compare October 5, 2023 09:56
@laurent-19
Copy link
Collaborator Author

Removed unused fmc pins for the ad4134_fmc SPI from pinout location description.

Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@laurent-19 laurent-19 merged commit cf4d2b5 into master Oct 19, 2023
1 of 2 checks passed
@laurent-19 laurent-19 deleted the update_ad4134_spi_engine branch October 19, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants