Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad5766 spi engine #1187

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Update ad5766 spi engine #1187

merged 2 commits into from
Oct 24, 2023

Conversation

PIoandan
Copy link
Collaborator

@PIoandan PIoandan commented Oct 3, 2023

PR Description

The functionality of the ad5766 project was verified with SPI Engine. Over the old version it was created the ad5766_fmc.txt file for generating the system_constr.xdc file. Also it was updated the system_constr.xdc and Readme.md files. Tested with NO-OS. No correct signals were obtained from the DAC output channels.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

In this project it was created the ad5766_fmc.txt file for generating the system_constr.xdc file.
Also it was updated the system_constr.xdc and Readme.md files.

Signed-off-by: Ioan-daniel Pop <[email protected]>
@laurent-19 laurent-19 self-requested a review October 5, 2023 12:12
laurent-19
laurent-19 previously approved these changes Oct 5, 2023
Copy link
Collaborator

@laurent-19 laurent-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All FMC pins seem covered properly.

Copy link
Collaborator

@laurent-19 laurent-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR include updating the SPIE hierarchy using the new SPIE script? Similar to cn0363 spi engine?
If not, the current changes seem fair to me.
Might be a good idea to state that the .txt contains a FMC pinout location description explicitly.

I edited the ad5766_fmc.txt file.

Signed-off-by: Ioan-daniel Pop <[email protected]>
@PIoandan
Copy link
Collaborator Author

Should this PR include updating the SPIE hierarchy using the new SPIE script? Similar to cn0363 spi engine? If not, the current changes seem fair to me. Might be a good idea to state that the .txt contains a FMC pinout location description explicitly.

The SPI Engine does not support custom offload modules.

@acostina acostina merged commit 2196809 into master Oct 24, 2023
1 of 2 checks passed
@acostina acostina deleted the update_ad5766_spi_engine branch October 24, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants