Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupiter sdr: Updates #1176

Merged
merged 4 commits into from
Sep 29, 2023
Merged

jupiter sdr: Updates #1176

merged 4 commits into from
Sep 29, 2023

Conversation

AndreiGrozav
Copy link
Contributor

@AndreiGrozav AndreiGrozav commented Sep 18, 2023 •
edited
Loading

PR Description

Fix DDS second channel sync.

PL sysmon updates:

  • add checks for a different power supply
  • connect pl_sysmon interrupt, required by the Linux driver.

Change SD card controller to autodir configuration.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@AndreiGrozav
axi_adrv9001: Change the DDS sync structure
984346d 
The DDS for each channel was synchronized by the main channel.
One problem with this aporoach is that when a user sets a DDS that
is not from the main channel the sinchronization does not happend.
This behavior is not user friendly in IIO-Oscilloscope or within other
configuration methods.

This commit keeps all channels in sync by triggering the sync on all
channels from each individual channel.
@AndreiGrozav
jupiter_sdr: PL sysmon updates
a2da70a 
Monitor VCC through VUSER1.
Disconnect the default redundant monitors.
Connect the pl_sysmon interrupt.
@AndreiGrozav
jupiter_sdr: Change the SD ctrl config to autodir
07c99a8
PopPaul2021
PopPaul2021 previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

acostina
acostina previously approved these changes Sep 25, 2023
View reviewed changes
@AndreiGrozav AndreiGrozav dismissed stale reviews from acostina and PopPaul2021 via ffdf092 September 26, 2023 07:01
@AndreiGrozav AndreiGrozav merged commit 8b07dfa into master Sep 29, 2023
1 of 2 checks passed
@AndreiGrozav AndreiGrozav deleted the dev_jupiter_sdr branch September 29, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alin724 alin724 alin724 approved these changes

@acostina acostina acostina approved these changes

@PopPaul2021 PopPaul2021 PopPaul2021 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreiGrozav @acostina @alin724 @PopPaul2021