Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging of make params to the sysid memory #1038

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Nov 2, 2022

Projects that can be configured using make parameters should now log their build parameters inside the sysid memory.
For some projects that have a lot of parameters the sysid memory address space was also increased to 1024.

Example:

root@analog:~# dmesg | grep sysid
[    3.555711] axi_sysid 45000000.axi-sysid-0: AXI System ID core version (1.01.a) found
[    3.562588] axi_sysid 45000000.axi-sysid-0: [ad_quadmxfe1_ebz] [64B66B RX:RATE=16.5 M=8 L=2 S=1 NP=16 LINKS=4 KS/CH=32 PLL_SEL=2 TX:RATE=16.5 M=16 L=4 S=1 NP=16 LINKS=4 KS/CH=16 PLL_SEL=2 REF_CLK=250 DAC_TPL_XBAR=0] on [vcu118] git branch <build_params_to_sysid> git <8c8dd8f923f19457769768c9bc8048290c1af9ba> dirty [2022-11-02 09:13:47] UTC

@bluncan bluncan requested a review from a team November 2, 2022 11:23
@acostina acostina requested a review from sarpadi November 3, 2022 12:06
@bluncan bluncan force-pushed the build_params_to_sysid branch from 45ba5cc to 2701c8a Compare April 11, 2023 10:07
@bluncan
Copy link
Contributor Author

bluncan commented Apr 11, 2023

v2: rebase to master and remove empty new lines from end of files

@bluncan bluncan requested a review from IuliaCMoldovan April 11, 2023 10:08
@bluncan bluncan force-pushed the build_params_to_sysid branch from 2701c8a to 9eba70f Compare April 11, 2023 10:57
@PopPaul2021 PopPaul2021 self-requested a review May 10, 2023 14:45
PopPaul2021
PopPaul2021 previously approved these changes May 12, 2023
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the rebase, it looks good to me!

projects/ad40xx_fmc/zed/system_bd.tcl Outdated Show resolved Hide resolved
projects/adrv9371x/zc706/system_bd.tcl Outdated Show resolved Hide resolved
projects/daq3/vcu118/system_bd.tcl Outdated Show resolved Hide resolved
projects/daq3/zc706/system_bd.tcl Outdated Show resolved Hide resolved
projects/daq3/zcu102/system_bd.tcl Outdated Show resolved Hide resolved
projects/fmcadc2/zc706/system_bd.tcl Outdated Show resolved Hide resolved
projects/cn0579/coraz7s/system_bd.tcl Outdated Show resolved Hide resolved
projects/fmcomms8/a10soc/system_qsys.tcl Outdated Show resolved Hide resolved
projects/adrv9001/a10soc/system_qsys.tcl Outdated Show resolved Hide resolved
projects/cn0501/coraz7s/system_bd.tcl Outdated Show resolved Hide resolved
@bluncan bluncan force-pushed the build_params_to_sysid branch from 9e6a238 to c98a881 Compare September 8, 2023 12:51
@bluncan
Copy link
Contributor Author

bluncan commented Sep 8, 2023

v3: Fixed missing \ and removed "sys rom custom string placeholder " from projects that don't have parameters

@bluncan bluncan force-pushed the build_params_to_sysid branch from c283e54 to 57cd954 Compare September 14, 2023 10:09
@gastmaier
Copy link
Contributor

gastmaier commented Jun 18, 2024

@bluncan , I created a rebased branch at build_params_to_sysid_rebased to resolve the merge conflicts.
If relevant, feel free to -f push the rebased branch into this one and re-request review.

@bluncan bluncan force-pushed the build_params_to_sysid branch from 36d4d10 to 63f5fa6 Compare July 16, 2024 08:10
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved the merge conflicts, ready to merge, considering the previous approval of changes in the initial review.

@gastmaier gastmaier requested a review from IuliaCMoldovan July 16, 2024 08:18
@gastmaier gastmaier dismissed IuliaCMoldovan’s stale review July 16, 2024 08:19

Requested changes were applied

@PopPaul2021 PopPaul2021 self-requested a review July 16, 2024 08:29
@bluncan bluncan merged commit 79be506 into main Jul 17, 2024
1 of 3 checks passed
@bluncan bluncan deleted the build_params_to_sysid branch July 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.