-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QATv2 updates, minor bug fixes #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhanbsolak
requested review from
rotx-eva,
alicangok,
ermanok,
MaximGorkem,
seldauyanik-maxim and
asyatrhl
September 2, 2024 10:30
When updating README.md, please also update README.pdf and create a matching PR in ai8x-synthesis |
ermanok
reviewed
Sep 24, 2024
oguzhanbsolak
force-pushed
the
qatv2
branch
2 times, most recently
from
September 25, 2024 14:09
445a2e0
to
fcbe1ff
Compare
alicangok
reviewed
Oct 7, 2024
alicangok
reviewed
Oct 7, 2024
alicangok
reviewed
Oct 7, 2024
alicangok
reviewed
Oct 7, 2024
seldauyanik
reviewed
Oct 8, 2024
seldauyanik
reviewed
Oct 8, 2024
seldauyanik
reviewed
Oct 8, 2024
seldauyanik
reviewed
Oct 8, 2024
seldauyanik
reviewed
Oct 8, 2024
seldauyanik
approved these changes
Oct 9, 2024
Added "test with best checkpoint" functionality |
ermanok
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
asyatrhl
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log:
1- QATv2
2- ActionTCN, AutoEncoder, FaceID_112 and MobileFaceNet_112 models are refactored for symbolic_trace() compatibility
3- EfficientNetv2 performance optimizations
4- Bug fixes:
a- Imagenet.py -> transforms.Normalize((0.485, 0.456, 0.406), (0.229, 0.224, 0.225)) was causing most of the inputs to be out of range for ai8x.normalize()
b- Train.py -> m.are_locations_wide should be a function call
c- Train.py -> For 8 bits classification, wide tests, the output should be divided with 128 instead of 256. Also, for the wide check, named_modules() is more robust than dict search.
d- ai8x.py -> fuse_bn_layers() is using the named_modules() now, as it works with the models that have nn.sequential modules as well
e- ai8x-blocks.py -> Refactoring depthwise_conv for layer naming convention