Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi:AD4170:Add support for AD4170 #31

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

jansunil
Copy link
Collaborator

@jansunil jansunil commented Jun 18, 2024

Add MATLAB support for AD4170

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation by running /docs/source/reference_api/gen_sysobj_doc.m script locally, if applies.

@jansunil
Copy link
Collaborator Author

@ribdp - Do these changes look good for a merge?

@ribdp
Copy link
Contributor

ribdp commented Jun 19, 2024

So the documentation would need some updates -

  1. We need to add the device name here and then run that script https://github.com/analogdevicesinc/PrecisionToolbox/blob/main/docs/source/reference_api/gen_sysobj_doc.m#L36
  2. Index.rst and ad4170_iio.rst would then get updated/generated, and would need to be added to the PR
  3. The existing CI/gen_doc changes can be removed as they aren't relevant to the new documentation system

@jansunil jansunil force-pushed the add-ad4170-matlab-support branch from 58f8c29 to f98c34c Compare June 19, 2024 09:32
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2024

CLA assistant check
All committers have signed the CLA.

@jansunil
Copy link
Collaborator Author

@ribdp - I've made the changes with the documentation- does it look ok now?

@ribdp
Copy link
Contributor

ribdp commented Jun 19, 2024

Just one final change from my end - the device needs to be mentioned here as well - https://github.com/analogdevicesinc/PrecisionToolbox/blob/main/docs/source/index.rst

LGTM otherwise

Add MATLAB support for AD4170

Signed-off-by: Janani Sunil <[email protected]>
@jansunil jansunil force-pushed the add-ad4170-matlab-support branch from f98c34c to 665144e Compare June 19, 2024 10:02
@jansunil
Copy link
Collaborator Author

Changelog: Added the AD4170 entry in the docs/source/index.rst

@jansunil jansunil merged commit 4870e76 into main Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants