Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jinja and selectors handling #131

Merged
merged 7 commits into from
Nov 11, 2022
Merged

update jinja and selectors handling #131

merged 7 commits into from
Nov 11, 2022

Conversation

cbouss
Copy link
Collaborator

@cbouss cbouss commented Nov 10, 2022 •
edited
Loading

Changes:

  • Updated jinja function handling to match conda-build spec --> no more crashes when processing pin_subpackage!
  • Use cbc files to process selectors --> not perfect but an improvement still
  • Report lines based on raw data

Should fix issues #126 #123 #118

This was linked to issues Nov 10, 2022
Linter fails on subsequent pin_subpackage lines #118
Closed
Line numbers shown on lints are not accurate to source code #123
Open
Yaml parsing error #126
Closed
marcoesters
marcoesters reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great, especially the code simplification.

Could you update the change log and add unit tests?

@cbouss
Copy link
Collaborator Author

cbouss commented Nov 10, 2022

I think this is great, especially the code simplification.

Could you update the change log and add unit tests?

Added info to changelog and tests for jinja functions and line report.

@cbouss cbouss mentioned this pull request Nov 11, 2022
Closed
@marcoesters marcoesters merged commit 80a3154 into main Nov 11, 2022
@marcoesters marcoesters deleted the jinja_and_selectors branch November 11, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoesters marcoesters marcoesters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cbouss @marcoesters