Fix type

amrabed · Aug 31, 2024 · b9529ab · b9529ab
1 parent 264804a
commit b9529ab
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 29 deletions.
diff --git a/src/data/positions.tsx b/src/data/positions.tsx
@@ -1,6 +1,6 @@
-import { Position } from "@/types";
+import { AnyPosition } from "@/types";
 
-const positions: Position[] = [
+const positions: AnyPosition[] = [
   {
     id: "sophi-manager",
     title: "Engineering Manager",
@@ -206,12 +206,12 @@ const positions: Position[] = [
       // "IoT",
       // "Smart City"
     ],
-    products: [
-      {
-        name: "Metrolab",
-        url: "https://github.com/amrabed/metrolab",
-      },
-    ],
+    // products: [
+    //   {
+    //     name: "Metrolab",
+    //     url: "https://github.com/amrabed/metrolab",
+    //   },
+    // ],
   },
   {
     id: "fujitsu",
@@ -237,7 +237,6 @@ const positions: Position[] = [
     ],
     skills: ["Docker", "PHP", "MySQL", "Metasploit"],
     tags: ["Security"],
-    products: [],
   },
   {
     id: "rhids",
@@ -269,16 +268,16 @@ const positions: Position[] = [
     ],
     skills: ["Java", "Docker", "Amazon AWS", "Shell"],
     tags: ["Cloud", "Security"],
-    products: [
-      {
-        name: "RHIDS",
-        url: "https://github.com/amrabed/rhids",
-      },
-      {
-        name: "strace-docker",
-        url: "https://github.com/amrabed/strace-docker",
-      },
-    ],
+    // products: [
+    //   {
+    //     name: "RHIDS",
+    //     url: "https://github.com/amrabed/rhids",
+    //   },
+    //   {
+    //     name: "strace-docker",
+    //     url: "https://github.com/amrabed/strace-docker",
+    //   },
+    // ],
   },
   {
     id: "sodacloud",
@@ -304,16 +303,16 @@ const positions: Position[] = [
     ],
     skills: ["Docker", "Amazon AWS", "Shell", "Maven"],
     tags: ["Mobile", "Cloud"],
-    products: [
-      {
-        name: "Docker-EC2",
-        url: "https://github.com/amrabed/docker-ec2",
-      },
-      {
-        name: "SodaCloud",
-        url: "https://github.com/VT-Magnum-Research/sodacloud",
-      },
-    ],
+    // products: [
+    //   {
+    //     name: "Docker-EC2",
+    //     url: "https://github.com/amrabed/docker-ec2",
+    //   },
+    //   {
+    //     name: "SodaCloud",
+    //     url: "https://github.com/VT-Magnum-Research/sodacloud",
+    //   },
+    // ],
   },
   {
     id: "minia-ta",

diff --git a/src/types.ts b/src/types.ts
@@ -55,6 +55,7 @@ export interface Organization {
   name: string;
   url: string;
   logo?: string;
+  department?: string;
 }
 
 export interface Certification {
@@ -86,3 +87,23 @@ export interface Position {
   tags: string[];
   roles: string[];
 }
+
+export interface Course {
+  id?: string;
+  title: string;
+  description?: string;
+  code?: string;
+  link?: string;
+  semester?: string;
+}
+
+export interface TeachingPosition extends Position {
+  courses?: Course[];
+}
+
+export interface ResearchPosition extends Position {
+  project?: string;
+  sponsors?: Organization[];
+}
+
+export type AnyPosition = TeachingPosition | ResearchPosition | Position;