Fix sonar issues

amrabed · Oct 20, 2024 · 9573d95 · 9573d95
1 parent be4d04f
commit 9573d95
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 18 deletions.
diff --git a/src/app/globals.css b/src/app/globals.css
@@ -13,10 +13,6 @@ div {
   text-align: justify;
 }
 
-/* .sectionHeading {
-  @apply px-4 text-center flex justify-center items-center text-3xl md:text-4xl font-medium dark:text-primary-dark text-primary pb-8 md:pb-10;
-} */
-
 /* Home Animation and About Animation */
 .slide-in {
   transform: translateX(0);

diff --git a/src/app/positions/timeline.tsx b/src/app/positions/timeline.tsx
@@ -22,9 +22,9 @@ const PositionView = ({ position }: { position: Position }) => (
     <Divider />
     <CardBody>
       <ul>
-        {position.tasks.map((task, index) => (
+        {position.tasks.map((task) => (
           <li
-            key={index}
+            key={task}
             className="text-sm font-medium leading-snug tracking-wide text-slate-500 dark:text-slate-400"
           >
             {task}
@@ -40,8 +40,8 @@ const PositionView = ({ position }: { position: Position }) => (
         <Tools tools={position.skills} />
       </div>
       <ul className="flex flex-row gap-2 text-zinc-400">
-        {position.roles.map((role, index) => (
-          <li key={index}>{role}</li>
+        {position.roles.map((role) => (
+          <li key={role}>{role}</li>
         ))}
       </ul>
     </CardFooter>

diff --git a/src/components/header.tsx b/src/components/header.tsx
@@ -68,8 +68,8 @@ export const MainHeader = () => {
       </NavbarContent>
 
       <NavbarContent className="hidden sm:flex gap-4" justify="start">
-        {sections.map((section, index) => (
-          <NavbarItem key={index}>
+        {sections.map((section) => (
+          <NavbarItem key={section.name}>
             <Link
               className={"hover:text-primary hover:dark:text-primary-dark"}
               href={section.link}
@@ -81,8 +81,8 @@ export const MainHeader = () => {
           </NavbarItem>
         ))}
         <Divider orientation="vertical" className="h-10 my-4" />
-        {pages.map((page, index) => (
-          <NavbarItem key={index}>
+        {pages.map((page) => (
+          <NavbarItem key={page.name}>
             <Link
               className={"hover:text-primary hover:dark:text-primary-dark"}
               href={page.link}
@@ -96,8 +96,8 @@ export const MainHeader = () => {
       </NavbarContent>
 
       <NavbarMenu className="dark:bg-background backdrop-blur-500 transition-all duration-1000">
-        {sections.map((section, index) => (
-          <NavbarMenuItem key={index}>
+        {sections.map((section) => (
+          <NavbarMenuItem key={section.name}>
             <Link
               className="hover:text-primary hover:dark:text-primary-dark"
               href={section.link}
@@ -110,8 +110,8 @@ export const MainHeader = () => {
           </NavbarMenuItem>
         ))}
         <Divider />
-        {pages.map((page, index) => (
-          <NavbarMenuItem key={index}>
+        {pages.map((page) => (
+          <NavbarMenuItem key={page.name}>
             <Link
               className={"hover:text-primary hover:dark:text-primary-dark"}
               href={page.link}

diff --git a/src/components/social.tsx b/src/components/social.tsx
@@ -4,8 +4,8 @@ import profiles from "@/data/profiles";
 
 const SocialMedia = () => (
   <div className="w-full p-2 z-10 flex flex-wrap justify-center items-center">
-    {profiles.map((profile, index) => (
-      <Tooltip key={index} content={profile.name}>
+    {profiles.map((profile) => (
+      <Tooltip key={profile.name} content={profile.name}>
         <Link href={profile.link} isExternal rel="noreferrer">
           <div className="bg-background rounded-full p-1">
             <Button