Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAI_ScriptedSequence crash #175

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix CAI_ScriptedSequence crash #175

merged 2 commits into from
Nov 25, 2024

Conversation

Alienmario
Copy link
Collaborator

Speculative fix for server_srv.so!CAI_ScriptedSequence::ScriptThink() + 0x149

Attempts to fix null reference on m_hTargetEnt inside CAI_ScriptedSequence::ScriptThink by preventing CAI_ScriptedSequence::StartScript from nullifying its own target entity.

This is currently being tested on the server.

@Alienmario Alienmario requested a review from ampreeT November 23, 2024 19:10
@ampreeT
Copy link
Owner

ampreeT commented Nov 24, 2024

I looked at the implementation of CAI_ScriptedSequence::StartScript and I did not see any logic that checks for sp/mp. Is this crashing in singleplayer too?

@Alienmario
Copy link
Collaborator Author

I looked at the implementation of CAI_ScriptedSequence::StartScript and I did not see any logic that checks for sp/mp. Is this crashing in singleplayer too?

Possibly. Just with more players passing through the map, entity inputs will get called more unpredictably, at increased rate.

Copy link
Owner

@ampreeT ampreeT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Alienmario Alienmario merged commit b244b23 into master Nov 25, 2024
2 checks passed
@Alienmario Alienmario deleted the scripted-sequence branch December 23, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants