Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page experience for fonts in core themes #6674

Merged
merged 22 commits into from
Nov 30, 2021
Merged

Improve page experience for fonts in core themes #6674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0be7466
The 'font-display' value replaced from 'swap' to 'optional'
bartoszgadomski Nov 2, 2021
dfbf616
Preload link added for all font files
bartoszgadomski Nov 2, 2021
df8fbc2
Test case for font files preloading added
bartoszgadomski Nov 3, 2021
5d282ce
Fix theme case to not execute assertions if a given theme is not inst…
bartoszgadomski Nov 3, 2021
1ab2a12
Reuse already parsed URL value and only preload first externalized da…
westonruter Nov 3, 2021
a5e6f6d
Harden collection of font sources
westonruter Nov 3, 2021
c5de528
Use data provider for test_font_files_preloading
westonruter Nov 3, 2021
4e0403f
Fonts preloading rules improved
bartoszgadomski Nov 9, 2021
503aa47
Fix failing tests due to font-display:optional
bartoszgadomski Nov 9, 2021
3eda2bc
Logic for 'font-display' property and fonts preloading improved
bartoszgadomski Nov 10, 2021
49c1103
Use LinkManager instead of AMP_DOM_Utils::create_node
bartoszgadomski Nov 10, 2021
009333b
Update request destination parameter
bartoszgadomski Nov 10, 2021
74ef48b
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/6036-…
westonruter Nov 16, 2021
4c5b586
Use font-display:block for font icon instead of font-display:auto
westonruter Nov 16, 2021
97f8497
Improve PHP CSS Parser API usage
westonruter Nov 16, 2021
7c6afe7
Add failing test case for no preload link being added when the first …
westonruter Nov 16, 2021
e02b96a
Font preload logic improved
bartoszgadomski Nov 17, 2021
95c7da2
Add another failing test to ensure preload links are added when parse…
westonruter Nov 17, 2021
6c16113
Eliminate redundant code
westonruter Nov 17, 2021
773395e
Only catch exceptions specific to php-css-parser when parsing
westonruter Nov 17, 2021
b3b6579
Ensure font preloads are added for cached stylesheets
westonruter Nov 17, 2021
96b748b
Bust stylesheet cache group
westonruter Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading