-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp comments handling for sandboxing levels #6577
Merged
westonruter
merged 16 commits into
add/sandboxing-levels
from
add/sandboxing-levels-with-comments
Sep 2, 2021
Merged
Revamp comments handling for sandboxing levels #6577
westonruter
merged 16 commits into
add/sandboxing-levels
from
add/sandboxing-levels-with-comments
Sep 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin builds for 7048f65 are ready 🛎️!
|
westonruter
force-pushed
the
add/sandboxing-levels
branch
from
September 1, 2021 21:00
d2dbc7c
to
632760c
Compare
westonruter
force-pushed
the
add/sandboxing-levels-with-comments
branch
from
September 2, 2021 04:22
24464e9
to
aa06a75
Compare
This was referenced Sep 2, 2021
* Raise error when `action-xhr` appears when native POST forms are used. * Eliminate redundant `amp_is_native_post_form_allowed()`. * Refine side effects of keeping non-AMP scripts vs PX-verified ones.
westonruter
force-pushed
the
add/sandboxing-levels-with-comments
branch
from
September 2, 2021 19:00
3e5d1a9
to
ee1c3ea
Compare
westonruter
added
the
Changelogged
Whether the issue/PR has been added to release notes.
label
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #6546.
This includes the full fix for #2489 going beyond the short-term fix introduced in #4388.
Upon clicking a link to reply to a comment by “admin”:
Also fixes #6231.
Fixes #4624.