Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp comments handling for sandboxing levels #6577

Merged

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Aug 29, 2021

Amends #6546.

This includes the full fix for #2489 going beyond the short-term fix introduced in #4388.

Upon clicking a link to reply to a comment by “admin”:

Non-AMP w/ JS Non-AMP w/o JS AMP Before 👎 AMP After 👍
image image image image

Also fixes #6231.
Fixes #4624.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2021

Plugin builds for 7048f65 are ready 🛎️!

@westonruter westonruter force-pushed the add/sandboxing-levels branch from d2dbc7c to 632760c Compare September 1, 2021 21:00
* Raise error when `action-xhr` appears when native POST forms are used.
* Eliminate redundant `amp_is_native_post_form_allowed()`.
* Refine side effects of keeping non-AMP scripts vs PX-verified ones.
@westonruter westonruter force-pushed the add/sandboxing-levels-with-comments branch from 3e5d1a9 to ee1c3ea Compare September 2, 2021 19:00
@westonruter westonruter added this to the v2.2 milestone Sep 2, 2021
@westonruter westonruter merged commit 213e0fc into add/sandboxing-levels Sep 2, 2021
@westonruter westonruter deleted the add/sandboxing-levels-with-comments branch September 2, 2021 19:58
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Sandboxing Experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant