Code

Improve handling of Tumblr embeds#5926

Code

Merged

westonruter merged 28 commits intodevelopampproject/amp-wp:developfrom fix/4757-tumblr-embed-validation-errorampproject/amp-wp:fix/4757-tumblr-embed-validation-errorCopy head branch name to clipboardMar 4, 2021

+345-30

Commits

Commits on Feb 25, 2021

• Sanitize Tumblr embeds

  pierlon

  committed
  9de2cfc

• Fix lint errors

  pierlon

  committed
  a414ddf

• Add test for https://teded.tumblr.com/post/184736320764/how-do-vaccines-work`

  pierlon

  committed
  ebd31df

• Use tagName instead of nodeName

  Show description for 9125cd6
  

  pierlon

  and

  westonruter

  authored
  9125cd6

• Remove escaping of text

  Show description for ca74ffa
  

  pierlon

  and

  westonruter

  authored
  ca74ffa

• Make use of tagName, use constants where possible, add phpdoc

  westonruter

  committed
  da37307

• Check if tumblr-post is apart of the list of classes

  Show description for 1475347
  

  pierlon

  and

  westonruter

  authored
  1475347

Commits on Feb 26, 2021

• Use callback to determine if script should be removed

  pierlon

  committed
  c330597

• Use button as overflow element

  pierlon

  committed
  7df8bbe

• Add bottom:0 to Tumblr overflow button

  westonruter

  committed
  3323625

Commits on Mar 3, 2021

• Make xpath predicate more specific and improve condition formatting

  westonruter

  committed
  8ae2574

• Remove extraneous parentheses

  westonruter

  authored
  005ea45

• Apply style rules for AMP iframe resize button via core sanitizer

  pierlon

  committed
  5c4b667

• Fix indentation

  pierlon

  committed
  6d4bef6

• Set button type

  Show description for f56f10c
  

  pierlon

  and

  westonruter

  authored
  f56f10c

Commits on Mar 4, 2021

• Add style rule to place overflow button in bottom left corner of AMP component

  pierlon

  committed
  2740d7e

• Make sure TT1 stylesheet is enqueued before adding inline style

  westonruter

  committed
  7da8a35

• Opt to combine add_twentytwentyone_overflow_button_fix into amend_twentytwentyone_styles

  westonruter

  committed
  f642be8

• Make sure that Tumblr embed has a link to use as a placeholder

  westonruter

  committed
  0c6666e

• Make use of MarkupComparison

  westonruter

  committed
  685bdc9

• Test removal of Tumblr script when wpautop was not involved

  westonruter

  committed
  435b6ad

• Add test for tumblr in embed block

  westonruter

  committed
  bcbdf00

• Remove extraneous sprintf()

  westonruter

  committed
  8fa44dd

• Combine conditions

  westonruter

  committed
  c482fcb

• Use xpath query to obtain the placeholder

  westonruter

  committed
  ce2b8b4

• Set placeholder attribute when we are sure we will match

  westonruter

  committed
  77c7367

• Remove extraneous sprintf()

  westonruter

  committed
  8839cc1

• Fix tests in WP 4.9

  westonruter

  committed
  ad2e9be