Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing npm dependency #4150

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Add missing npm dependency #4150

merged 1 commit into from
Jan 21, 2020

Conversation

swissspidy
Copy link
Collaborator

Summary

Gutenberg itself doesn't seem to be using the nux package anymore, which means the package might not actually be available when being used in amp-preview.js. See WordPress/gutenberg#18041

This PR fixes that by explicitly adding it as a dev dependency, unblocking #4087 and preventing potential future issues.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 21, 2020
@swissspidy swissspidy merged commit 9da56af into develop Jan 21, 2020
@swissspidy swissspidy deleted the fix/missing-dependency branch January 21, 2020 15:32
@westonruter westonruter added this to the v1.5 milestone Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@pierlon pierlon Awaiting requested review from pierlon

@kienstra kienstra Awaiting requested review from kienstra

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Integration: Gutenberg
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@swissspidy @westonruter @googlebot