Code

Allow drag to different page#3312

Code

Merged

swissspidy merged 37 commits intodevelopampproject/amp-wp:developfrom feature/3311-allow-drag-to-pageampproject/amp-wp:feature/3311-allow-drag-to-pageCopy head branch name to clipboardOct 4, 2019

+689-177

Commits

Commits on Sep 20, 2019

• Allow drag to different page

  Show description for 6e37b45
  barklund

  committed
  6e37b45

• Refactor duplicated logic

  barklund

  committed
  ba20251

• Remove unnecessary hook

  barklund

  committed
  354443b

Commits on Sep 23, 2019

• More performant structure

  barklund

  committed
  40259f8

• Better separation of concerns

  barklund

  committed
  9fd43c3

• Handle CTA blocks correctly when dragging between pages

  Show description for 305b692
  barklund

  committed
  305b692

• Fix proptypes and add inline comment

  barklund

  committed
  f7d0c19

• Fix offset bug when dragging 2+ pages left

  barklund

  committed
  83b2e4f

Commits on Sep 24, 2019

• Adding documentation for functions

  barklund

  committed
  3928f60

• Fix disallow duplicate CTA

  barklund

  committed
  efd22fd

Commits on Sep 26, 2019

• Generalised helper for checking if block is allowed on given page

  Show description for 95ca6c8
  barklund

  committed
  95ca6c8

• Refactored isCTABlock to helpers

  Show description for 6109bec
  barklund

  committed
  6109bec

Commits on Sep 27, 2019

• Rename variable and move to constants

  barklund

  committed
  b3be9f5

• Merge branch 'develop' into feature/3311-allow-drag-to-page

  barklund

  committed
  0395f30

• Make props required where applicable

  barklund

  committed
  04fffea

• Reorganised helper to aid in testing

  Show description for 3c7afcf
  barklund

  committed
  3c7afcf

• Fix typos

  barklund

  committed
  aee7550

• Reuse STORY_PAGE_MARGIN where applicable

  barklund

  committed
  64f341d

• Missing rewrite to isCTABlock fixed

  barklund

  committed
  5160c2f

• Fix minor errors in rewrites

  barklund

  committed
  9bcb884

• Add aria-grabbed to the block mover

  barklund

  committed
  7ee41f3

• Revert "Add aria-grabbed to the block mover"

  Show description for 3b8a139
  barklund

  committed
  3b8a139

Commits on Sep 30, 2019

• Fix test wording

  barklund

  committed
  4f4f619

Commits on Oct 1, 2019

• Updated component documentation

  barklund

  committed
  d1813e1

• Updated logic to display non-allowed drop zones

  Show description for c3e51f4
  barklund

  committed
  c3e51f4

• Add border on allowed regions instead (and fix css lint)

  barklund

  committed
  4041030

Commits on Oct 2, 2019

• Major rewrite of entire implementation

  Show description for 1cde15c
  barklund

  committed
  1cde15c

Commits on Oct 3, 2019

• Merge branch 'develop' into feature/3311-allow-drag-to-page

  barklund

  committed
  3f13272

• Convert helper function to hook

  Show description for e963844
  barklund

  committed
  e963844

• Added dependencies for useSelect

  barklund

  committed
  3241e3b

• Created new constant for the height of the drop zone for CTAs

  barklund

  committed
  005bac0

• Updated useMoveBlockToPage and added tests

  Show description for 354ee52
  barklund

  committed
  354ee52

• Fix proptype missed in refactor

  barklund

  committed
  8f068be

Commits on Oct 4, 2019

• Merge branch 'develop' into feature/3311-allow-drag-to-page

  swissspidy

  committed
  d5eb6a8

• Refactor MediaInserter to use hooks

  Show description for 144c430
  swissspidy

  committed
  144c430

• Move isBlockAllowedOnPage function inline

  Show description for 60f0198
  swissspidy

  committed
  60f0198

• Remove ifCondition HOC usage from stories editor

  swissspidy

  committed
  9bd9ab3