Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust block inserter style. #3075

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Adjust block inserter style. #3075

merged 3 commits into from
Aug 22, 2019

Conversation

miina
Copy link
Contributor

@miina miina commented Aug 22, 2019

Fixes #3062.

Before:
Screenshot 2019-08-21 at 18 03 09

After:
Screenshot 2019-08-22 at 10 35 21

@miina miina requested a review from swissspidy August 22, 2019 07:36
@googlebot googlebot added the cla: yes Signed the Google CLA label Aug 22, 2019
@miina miina added this to the v1.2.1 milestone Aug 22, 2019
@swissspidy
Copy link
Collaborator

I wonder which Gutenberg change caused this. I only found WordPress/gutenberg#16813 so far that could be relevant. That PR also makes me wonder how/if we're going to implement that same feature in the future... 🤔

@miina
Copy link
Contributor Author

miina commented Aug 22, 2019

I wonder which Gutenberg change caused this. I only found WordPress/gutenberg#16813 so far that could be relevant. That PR also makes me wonder how/if we're going to implement that same feature in the future...

Yep, that's the PR that caused the change.

I'm thinking that since right now we will release before the new feature comes out then the Inserter should look OK in both cases, that's why maybe it wouldn't make sense to move over to the new style and markup right now fully. However, for 1.2.2 we could apply the changes, we could also then consider changing the classnames so that we wouldn't be influenced by upstream changes. Thoughts?

@miina miina requested a review from swissspidy August 22, 2019 08:18
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@swissspidy swissspidy merged commit 55e9006 into develop Aug 22, 2019
@swissspidy swissspidy deleted the fix/3062-inserter-style branch August 22, 2019 11:25
westonruter added a commit that referenced this pull request Aug 22, 2019
* tag '1.2.1': (434 commits)
  Bump 1.2.1
  Adjust block inserter style. (#3075)
  Update dependency eslint-plugin-jest to v22.15.2
  Fix flaky CTA test (#3057)
  Add more resizing handles (#3023)
  Bump version to 1.2.1-RC1
  Improve story page background media with image srcset, reduced image size, and a11y text (#3006)
  Wait until content loaded before calculating font size. (#3052)
  Harden logic for normalizing image metadata before adding story images (#3049)
  Update dependency uuid to v3.3.3 (#3046)
  Inline color support (#3033)
  Update dependency webpack-cli to v3.3.7 (#3040)
  Tiny prop-types fix
  Update dependency babel-jest to v24.9.0 (#3037)
  Update e2e test setup (#3031)
  Include amp-script among dynamic_element_selectors in tree shaking
  Another try to fix tests.
  Ensure selecting the first page before removing the block.
  Move setting input selection to the end to helpers.
  Fix editor test.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Inserter looks broken on upstream develop branch
3 participants