Improve generation of AMP pages in post-processor #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
update/template-head
branch
from
f911cb2 to
3c2a784
Compare
westonruter
force-pushed
the
update/template-head
branch
3 times, most recently
from
5fff2fa to
d685ba5
Compare
…dividual boilerplate stylesheets
westonruter
force-pushed
the
update/template-head
branch
from
e6260da to
06428cd
Compare
westonruter
changed the title
schlessera
requested changes
Aug 30, 2019
Co-Authored-By: Alain Schlesser <[email protected]>
Co-Authored-By: Alain Schlesser <[email protected]>
schlessera
approved these changes
Sep 3, 2019
|
E2E tests are failing, probably for unrelated reasons. |
This was referenced Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp_story_headaction which plugins (e.g. Jetpack and Yoast) can use to inject additional metadata. Note thatamp_story_footeraction is not included because there is no clear use case for it yet in Stories. Fixes Allow plugins to add metadata to AMP Stories #2968.<html>and<head>. Pass-through HTML fragments unmodified, similar to passing-through JSON. Fixes HTML fragment responses are erroneously converted into incomplete AMP documents #1778.v0.js, rather than relying onwp_headaction to do so. This eliminates duplicate code and makes AMP template generation more robust. Note that the logic in\AMP_Theme_Support::ensure_required_markup()should eventually be broken into a separate sanitizer, especially as part of the optimized AMP work (Enable generation of Optimized (aka Transformed) AMP pages #958).