Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit validation results from At a Glance if Website not enabled #2570

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jun 11, 2019

Amends #2550.

Before

When the Website experience is disabled, the AMP error count is shown on the Dashboard “At a Glance” widget:

image

After

This PR prevents that from being included if Website is not enabled:

image

This aligns the behavior with the AMP admin screen, where when Website is enabled you can see:

image

But when disabled:

image

The compatibility tool should not be displayed in the UI when website is not enabled.

@westonruter westonruter added this to the v1.2 milestone Jun 11, 2019
@westonruter westonruter requested a review from amedina June 11, 2019 22:23
@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 11, 2019
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@westonruter westonruter merged commit 13114be into develop Jun 11, 2019
@westonruter westonruter deleted the remove/validation-stats-from-at-a-glance branch June 11, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants