Code

Improve URL Listing view#1397

Code

Merged

westonruter merged 63 commits intodevelopampproject/amp-wp:developfrom 1362-improved_url_listing_viewampproject/amp-wp:1362-improved_url_listing_viewCopy head branch name to clipboardSep 16, 2018

+387-139

Commits

Commits on Aug 30, 2018

• Start with listing view design improvements.

  miina

  committed
  0131c71

Commits on Sep 4, 2018

• Merge remote-tracking branch 'origin/develop' into 1362-improved_url_listing_view

  miina

  committed
  1e2dccf

• Add icons. Add tooltip skeleton. Fix sources.

  miina

  committed
  fd51be5

Commits on Sep 6, 2018

• Conform to validation error data model.

  Show description for 8ab7166
  kienstra

  committed
  8ab7166

• Merge in develop, resolve conflict.

  Show description for b31d123
  kienstra

  committed
  b31d123

• Update status names to latest design

  Show description for 99a35b8
  kienstra

  committed
  99a35b8

• Use dashicons for tooltip icon

  jacobschweitzer

  committed
  e263b55

• Add admin-tables.css file

  jacobschweitzer

  committed
  9e99f1a

• Hide tooltip

  jacobschweitzer

  committed
  273cccf

• Target class instead of id and add color to icon

  jacobschweitzer

  committed
  df68ed8

• Change Plug-In to Plugin

  jacobschweitzer

  committed
  54ae458

• Fix variable typo

  jacobschweitzer

  committed
  4075cb0

• Add plugin icon with color from design

  jacobschweitzer

  committed
  9094366

• Add theme icon with color

  jacobschweitzer

  committed
  604c4b9

• Remove extra linebreaks

  jacobschweitzer

  committed
  90b4920

• Add containers around sources for styling

  jacobschweitzer

  committed
  0be3a56

• Add margins around sources containers

  jacobschweitzer

  committed
  1cb3da7

• Add color to WP icon

  jacobschweitzer

  committed
  49ca0d8

• Change wording - found to removed

  jacobschweitzer

  committed
  6d7f35b

• Add icons to status column

  jacobschweitzer

  committed
  f6a0878

• Add amp logo icon class

  jacobschweitzer

  committed
  c71addb

• Add error-status class

  jacobschweitzer

  committed
  ca2e7d2

• Style error statuses

  jacobschweitzer

  committed
  36564fd

• Add closing span tag

  jacobschweitzer

  committed
  736b2f2

• Add color to removed elements column text

  jacobschweitzer

  committed
  7af56d6

• Add class to warning icons for styling

  jacobschweitzer

  committed
  25ab2b3

• Add color to identified and rejected icons

  jacobschweitzer

  committed
  139883e

• Fix translation functions, switch to esc_html__

  jacobschweitzer

  committed
  2583e44

Commits on Sep 7, 2018

• Add plugins icon when there is multiple plugins

  jacobschweitzer

  committed
  8649b91

Commits on Sep 10, 2018

• Hide invalid sources if more than 1 and add icon

  jacobschweitzer

  committed
  53021cc

• Only enqueue stylesheet on its post type screens

  jacobschweitzer

  committed
  e87cca2

• Add common container class for sources

  jacobschweitzer

  committed
  8aebc0c

• Add JS for admin tables expand and collapse

  jacobschweitzer

  committed
  9ae7e58

• Add margin after source container

  jacobschweitzer

  committed
  ffb3fdc

• Merge branch 'develop' into 1362-improved_url_listing_view

  Show description for ab73ddf
  jacobschweitzer

  committed
  ab73ddf

• Remove todo

  jacobschweitzer

  committed
  4f14433

• Change wording: Removed to Invalid

  jacobschweitzer

  committed
  bda4140

• Wrap in <code> and add brackets for attributes

  jacobschweitzer

  committed
  c5ad3e6

• Fix translation function reference

  jacobschweitzer

  committed
  4ea9638

• Add double arrow to Sources column

  jacobschweitzer

  committed
  392ee24

• Add hide all sources functionality and styles

  jacobschweitzer

  committed
  163908e

Commits on Sep 11, 2018

• Change new status icons based on AMP options

  jacobschweitzer

  committed
  0ad0cf6

• Combine duplicated post_row_actions filters; ensure only relevant links included

  westonruter

  committed
  d4b586f

• Re-use AMP_Validation_Manager::is_sanitization_forcibly_accepted()

  westonruter

  committed
  1ab6bd3

• Add view errors by type title link button

  jacobschweitzer

  committed
  7eafdc6

• Change title of page and highlight word URL

  jacobschweitzer

  committed
  5b9b243

• Bolder font weight for page title action link keyword

  jacobschweitzer

  committed
  52babee

• ESLint fixes

  jacobschweitzer

  committed
  8f88d0c

Commits on Sep 12, 2018

• Fix PHP 5.3 compatibility issues

  jacobschweitzer

  committed
  1d95cae

• Update tests to reflect changes

  jacobschweitzer

  committed
  a4bdee9

• Update to tests and add an error check

  jacobschweitzer

  committed
  fe7e4de

Commits on Sep 13, 2018

• Address unit test errors

  Show description for 6936f05
  kienstra

  committed
  6936f05

• Merge branch 'develop' into 1362-improved_url_listing_view

  kienstra

  committed
  4cbee48

• Addres PHPCS warning by aligning =

  Show description for 2ce2e5e
  kienstra

  committed
  2ce2e5e

• Get full plugin names and fix theme source output

  jacobschweitzer

  committed
  74feb85

• Code review changes and text changes

  jacobschweitzer

  committed
  5baae3f

Commits on Sep 14, 2018

• Unify JS for text expansion and update styles

  jacobschweitzer

  committed
  6911305

• Implement workaround to fix JS not loading issue

  jacobschweitzer

  committed
  56915da

Commits on Sep 15, 2018

• Update unit tests based on latest changes

  jacobschweitzer

  committed
  6488c05

• Merge branch 'develop' into 1362-improved_url_listing_view

  jacobschweitzer

  committed
  88e7b7e

• Fix test listing amp plugin

  jacobschweitzer

  committed
  145a9ef

• Fix unit tests

  jacobschweitzer

  committed
  6624e68

Commits on Sep 16, 2018

• Apply remaining changes from code review

  Show description for 716a869
  westonruter

  committed
  716a869