-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test AMP compatibility of entire site #1183
Merged
Merged
Changes from 88 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
305c28b
Begin testing of site urls, starting with helper method.
kienstra 9e9df92
Change helper method to output IDs, for use with existing method.
kienstra fd50993
Change method name in test, assign $post_ids.
kienstra 1324044
Query for the latest posts, instead of by ID.
kienstra 3c4db61
Change helper method to get post permalinks.
kienstra bbfafa4
Add a method to get links for public terms.
kienstra db54a53
Also get links for post_format terms.
kienstra 6713ff3
Begin to apply review suggestion for get_taxonomy_links().
kienstra 2655310
Add an $offset parameter to get_taxonomy_links().
kienstra 32ab635
Add (optional) to the @param tag for $offset.
kienstra 1a862c7
Pass 'fields' => 'ids' to WP_Query().
kienstra c250bd5
Allow paging through posts in get_post_permalinks().
kienstra 71f7543
Add a method to crawl the entire site.
kienstra 4aade51
Address Travis error by using full class name, not self::
kienstra 584ffea
Force theme support of 'amp' on validation requests.
kienstra ae4371c
Add an 'amp' query arg if it's in Paired Mode.
kienstra 7b67efe
Begin WP-CLI script to crawl the site.
kienstra 15ec0ed
Display the number of validation issues in the sucess message:
kienstra 1ef10a7
Site crawling script: output 'more detail' link.
kienstra ba08f3d
Update PR for latest changes to validator, merge develop.
kienstra bfe37a8
Register a WP-CLI command: wp amp validate-site
kienstra 3d9a01c
Call the WP-CLI tick() method for every URL validated.
kienstra c586c24
Remove 'This might take a while...'
kienstra 128ca9c
Only report unaccepted validation errors.
kienstra 441044f
Remove the return value of validate_entire_site_urls().
kienstra 875d4ee
Address PHPCS error by aligning =
kienstra 4e8c00c
Remove function that forced AMP theme support.
kienstra c4b8f5f
Go back to displaying total errors,
kienstra c28e5ee
Remove wrapping in add_query_arg()
kienstra b6393cc
Fix the progress bar, by making counts more accurate.
kienstra c638e7e
Align = to address failed Travis build.
kienstra ad43100
Remove empty lines to address Travis issue.
kienstra 5af8dc9
Output a count of unaccepted errors.
kienstra adcb901
Stop storing the validated URLs in a property.
kienstra 9d11439
Make count_posts_and_terms() private.
kienstra 5e19020
Improve PHP DocBlocks.
kienstra f4e6bfd
Address failed unit test.
kienstra 8e1b031
Make function static, and other documentation changes
kienstra a4c1f7a
Merge branch 'develop' into valid-site
kienstra ce2b044
Add to DocBlock, remove needless empty line.
kienstra cd1d09e
Remove 'posts_per_page' => -1 from WP_Query arguments
kienstra edfdd65
Address failed unit test
kienstra 19f4feb
Address Travis error by aligning =.
kienstra e34ebda
Merge branch 'develop' into valid-site
kienstra 57411c6
Remove extra conditional block to call tick()
kienstra 6802175
Improve documentation, remove duplicated code.
kienstra a53bb45
Add a way to force crawling non-AMP-enabled URLs
kienstra d44cde9
Exclude taxonomy templates if the user has unchecked them
kienstra 71f4fcb
Add a flag to force validation of the entire site (but not yet implem…
kienstra ff3a5c0
Allow crawling templates the user has unchecked in 'Supported Templates'
kienstra d378a37
If there are no AMP-enabled taxonomies, don't count them.
kienstra 4f8b3e9
Add an argument --include to the WP-CLI command.
kienstra 4ea25bf
Implement the --include argument for taxonomies and posts
kienstra dadab10
Validate author pages, including with include=is_author
kienstra c687ea0
Validate the search template
kienstra 09fa083
If there are no URLs to crawl, call WP_CLI:error()
kienstra eadb61c
Merge branch 'develop' into valid-site
kienstra e8717fd
Update dev-lib: Install WP-CLI after installing WordPress on Travis CI
westonruter 13a0cc7
Ensure WP-CLI is available for deploy script
westonruter f054f13
Update Node so that Object.values is available
westonruter be32dcf
Refactor get_author_page_urls() to use round-robin validation
kienstra ff8d365
Refactor validate_entire_site_url() to use round-robin validation
kienstra 1387c5b
Apply the maximum URL property to count_urls_to_validate()
kienstra 41cffdc
Add a --max-url-count argument
kienstra 0202432
Account for the homepage in the --include argument
kienstra bff8fc7
Refactor validate_urls() to validate a single URL
kienstra 5d0d464
Display the validity by template type, like category: 15/16
kienstra 86cd224
Get the date template, and validate it
kienstra c31fa0e
Remove default value in get_taxonomy_links()
kienstra be8d552
Remove exclusion of attachments from tests, other documentations
kienstra 3dac2fd
Test removing the array_merge() call (will probably revert)
kienstra fe8eab3
Revert "Test removing the array_merge() call (will probably revert)"
kienstra b741f01
Merge branch 'develop' into valid-site
kienstra 4cf9e9d
Account for the date page in the initial count
kienstra 907facd
If there are no matched templates from --include, output error.
kienstra 52ff854
Merge branch 'develop' of https://github.com/Automattic/amp-wp into v…
westonruter ab9c2d9
Tidy static analysis complaints
westonruter 1f8f40b
Rename AMP_Site_Validation to AMP_CLI; init even in Classic mode
westonruter aca16f4
Refactor AMP_CLI to use methods as subcommands
westonruter 2637fb8
Ignore auto-sanitization when looking for unaccepted errors
westonruter da22efc
In Classic Mode, call WP_CLI::error() if the --force flag isn't present
kienstra bfadbe2
Allow validating the site in 'Classic' mode
kienstra 30f7522
Fix phpdoc for WP-CLI
westonruter e1760aa
Prevent crawling search or date URLs if empty; use for loop
westonruter ad7e0e2
Show warning when validate_url call fails
westonruter 7a52751
Fix classic mode site validation by forcing native mode
westonruter 8e2d028
Re-use amp_validate query param for forcing AMP theme support in clas…
westonruter edcb23a
Unconditionally initialize validation manager w/ registered post type…
westonruter 0e9bf1b
Switch to query posts in descending order for improved recency releva…
westonruter a83a569
Simplify should_show_in_menu return condition
westonruter 19ead16
Fix grammar typo in CLI success message
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be the best approach, but there probably has to be some way to validate URLs where AMP is disabled.
Like if a user unchecked 'Categories' in 'AMP Settings' > 'Supported Templates,' this will need to be able to validate categories if the command is:
or