Adding Post Comments Form block to post causes validation error for comment-reply enqueued script

[westonruter]

Bug Description

As part of Full Site Editing, Gutenberg has a “Post Comments Form” block:

This renders the standard comments form inside the post content:

When viewing such a post on the frontend, a validation error is reported:

Normally the comment-reply form is dequeued when the singular template is loaded:

amp-wp/includes/class-amp-theme-support.php

Lines 901 to 906 in 1c7728c

	add_action(
	'wp_enqueue_scripts',
	static function() {
	wp_dequeue_script( 'comment-reply' ); // Handled largely by AMP_Comments_Sanitizer and *reply* methods in this class.
	}
	);

This doesn't work for the block, however, because the script is enqueued as part of the render callback.

This is the second block we've seen in core to enqueue a script, the first being the File block which we added support for in #6112. We may need to take a similar approach where we dequeue the script just-in-time at wp_print_scripts /wp_print_footer_scripts. For example:

--- a/includes/class-amp-theme-support.php
+++ b/includes/class-amp-theme-support.php
@@ -898,12 +898,12 @@ static function() {
 			},
 			0
 		);
-		add_action(
-			'wp_enqueue_scripts',
-			static function() {
-				wp_dequeue_script( 'comment-reply' ); // Handled largely by AMP_Comments_Sanitizer and *reply* methods in this class.
-			}
-		);
+
+		$dequeue_comment_reply = static function() {
+			wp_dequeue_script( 'comment-reply' ); // Handled largely by AMP_Comments_Sanitizer and *reply* methods in this class.
+		};
+		add_action( 'wp_print_scripts', $dequeue_comment_reply, 0 );
+		add_action( 'wp_print_footer_scripts', $dequeue_comment_reply, 0 );
 	}
 
 	/**

Note also that the source of this script is erroneously being reported as Twenty Twenty-One when it should be Core.

Expected Behaviour

Steps to reproduce

0. Activate Gutenberg.
1. Add the Post Comments Form to the content
2. Validate the AMP page.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

[delawski]

QA Passed

✅ After activating the TT1 Blocks theme and adding a Post Comments Form to a post, I got no "Invalid script" validation issue:

Note that there was no Post Comments Form available in the regular Twenty Twenty-One theme. Following the instruction on make.wordpress.org, I went ahead and installed the TT1 Blocks theme.

Tested on AMP Version 2.2.0-alpha-20211123T020732Z-5405daa

[delawski]

@westonruter While QA'ing this issue, I've noticed a potential new issue.

The TT1 Blocks theme replaces the default theme header with a block-based template part. The template part uses a Navigation block which seems to be enqueuing yet another script, gutenberg/build/block-library/blocks/navigation/view.min.js. Similarly to comment-reply.js, it causes an AMP validation error:

Should I create a new bug report for that or will we take care of FSE and TT1 Blocks theme later (as I think there might be more blocks causing similar errors)?

[westonruter]

@delawski I think this will be addressed by #6319 for #6649. So I think this is captured already and it's being tracked for v2.3.