Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix remote evaluation example in README file #11

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

thetechdabbler
Copy link
Contributor

Fixed the example provided in README file, which was not working

@tyiuhc
Copy link
Collaborator

tyiuhc commented Dec 13, 2023

@thetechdabbler Many thanks for raising this! For future reference, we recommend that our dev docs be used as the most up-to-date reference for the SDK

@tyiuhc tyiuhc changed the title Fixed the example given in README file docs: Fixed local evaluation example in README file Dec 13, 2023
@tyiuhc tyiuhc changed the title docs: Fixed local evaluation example in README file docs: Fix local evaluation example in README file Dec 13, 2023
@tyiuhc tyiuhc changed the title docs: Fix local evaluation example in README file docs: Fix remote evaluation example in README file Dec 13, 2023
@tyiuhc tyiuhc merged commit 5d991a8 into amplitude:main Dec 13, 2023
3 checks passed
@thetechdabbler
Copy link
Contributor Author

@tyiuhc, the similar typo is present in dev docs as well. The example provided is not working.
The line $variants = $client->fetch($user)>wait(); should be replaced with $variants = $client->fetch($user)->wait();

@tyiuhc
Copy link
Collaborator

tyiuhc commented Dec 14, 2023

@thetechdabbler Dev docs now have been updated to address this. Thanks again for your contribution!

Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants