Update variant() to use local evaluation and update exposure tracking with new fields #32

tyiuhc · 2023-09-25T22:14:23Z

No description provided.

…d-variant

bgiori

great start, still need all those tests, let me know if you need to know which ones to write.

sdk/src/main/java/com/amplitude/experiment/DefaultExperimentClient.kt

Tim Yiu and others added 30 commits September 14, 2023 09:36

rebase

d0bd9a9

variant changes

18ab28d

initial ExperimentClient changes

91f754b

make loadstorecache functions public

8bac8d7

use synchronize instead of mutex

2f14a22

clean up

d267158

update with ExperimentClient and implement getFlagStorage

164b23e

add StorageTest

9a5e3d5

DefaultExperimentClient takes Storage instead of application

b80196e

fix ExperimentClientTest

4ff3fa3

update Cache load function

60fe73a

Merge branch 'local-evaluation' into update-expclient-with-storage-an…

9072a9b

…d-variant

update to java 9

251fbb5

test using java 9

8a0de32

update build.yml

13e41ed

lower mockito version

a9b760f

chore: remove unneeded imports

b12af15

make classes internal

70a3038

clean up imports

7456554

fix VariantTest and Variant.toJson()

e54024c

update cache with flags

6377faf

make transformVariantFromStorage() internal

6ea5aa1

add flagapi

31998ac

rebase

260995d

variant changes

65e4cd0

initial ExperimentClient changes

5cc190b

make loadstorecache functions public

bd7af66

use synchronize instead of mutex

7a0533b

update with ExperimentClient and implement getFlagStorage

a83a4f8

add StorageTest

0fe933e

Tim Yiu and others added 19 commits September 21, 2023 10:58

update build.gradle and import remaining evaluation-core files

8bb7444

update shareprefsstorage and cache logic

77d390b

fix VariantTest

d4289b8

update String.toFlag

528dcaf

update Flag/Variant utils

50685c6

update String.toVariant payload handling

58be549

update evaluation package, LoadStoreCache

606c306

fix getFlags

a4cc3fa

remove flag!=null after decodeFromString

ea962e4

update expClient

1473a32

update storage and fallback logic

32a34f3

Merge branch 'local-evaluation' into update-expclient-variant

09f7109

fix code style

28fd0b3

update variant to use new exposureInternal

5abbc5a

update exposureInternal hasDefaultVariant check

b42db02

remove convertVariant()

ee7379c

nit: isNull() to isNullOrEmpty()

a2d63e9

remove backticks on isNullOrEmpty()

a8799ff

codestyle

08ae2d7

tyiuhc marked this pull request as ready for review September 26, 2023 21:46

tyiuhc requested a review from bgiori September 26, 2023 21:46

bgiori requested changes Sep 26, 2023

View reviewed changes

Tim Yiu added 2 commits September 27, 2023 13:00

resolve comments

1147b29

code style

bb6a2bd

tyiuhc requested a review from bgiori September 27, 2023 21:07

fix build

d4a369f

bgiori approved these changes Sep 29, 2023

View reviewed changes

sdk/src/main/java/com/amplitude/experiment/DefaultExperimentClient.kt Show resolved Hide resolved

remove user session tracking from legacyExposureInternal

cfaea55

tyiuhc merged commit 11e46c2 into local-evaluation Sep 29, 2023
3 of 4 checks passed

tyiuhc deleted the update-expclient-variant branch September 29, 2023 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update variant() to use local evaluation and update exposure tracking with new fields #32

Update variant() to use local evaluation and update exposure tracking with new fields #32

tyiuhc commented Sep 25, 2023

bgiori left a comment

Update variant() to use local evaluation and update exposure tracking with new fields #32

Update variant() to use local evaluation and update exposure tracking with new fields #32

Conversation

tyiuhc commented Sep 25, 2023

bgiori left a comment

Choose a reason for hiding this comment