Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial Session Replay commit #2

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat: Initial Session Replay commit #2

merged 1 commit into from
Aug 14, 2024

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Aug 14, 2024

Summary

Please ignore anything in Frameworks/AmplitudeSessionReplay.xcframework/* for review as this is a generated artifact.

  • Adds a compiled session replay xcframework
  • Adds AmplitudeSwiftSessionReplayPlugin for integration with AmplitudeSwift
  • Adds AmplitudeiOSSessionReplayMiddleware for integration with Amplitude-iOS
  • Adds SPM support
  • Adds basic CocoaPods support

TODO (requires a public repo):

  • Test Carthage
  • See if we can add the middleware/plugin as Cocoapods subspec, which makes integration a bit easier.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: Yes

@crleona crleona requested a review from a team August 14, 2024 00:34
izaaz
izaaz previously approved these changes Aug 14, 2024
View reviewed changes
@crleona crleona force-pushed the initial_session_replay_commit branch from ee13d1d to e2a3905 Compare August 14, 2024 17:39
@crleona crleona requested a review from izaaz August 14, 2024 17:47
@crleona crleona merged commit d24d156 into main Aug 14, 2024
1 check passed
@crleona crleona deleted the initial_session_replay_commit branch August 14, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaaz izaaz izaaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crleona @izaaz