Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix the dependency issue #709

Merged
merged 2 commits into from
Apr 9, 2024
Merged

build: fix the dependency issue #709

merged 2 commits into from
Apr 9, 2024

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Apr 8, 2024

Summary

While graduate the beta version, github action cannot recognize the latest change in React Native and Node.

Screenshot 2024-04-08 at 5 03 54 PM

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

yarn.lock Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@yuhao900914
Copy link
Contributor Author

yuhao900914 commented Apr 9, 2024

Sync with Justin, why we use 2.0.0-beta.0 in node and react is because there is no 2.0 for node and react-native. And we have not published them yet. So this shouldn't be changed. Will close this pr.
However, it's preventing me to graduate the analytics-browser SDK. It might be the issue between this pr and the graduate process.

Update:
Both node and react-native have been marked as private repos. Bumpup the version in the package.json won't release either of the packages. Thanks @kevinpagtakhan for providing the info.
cc: @justin-fiedler

@yuhao900914 yuhao900914 merged commit c84e997 into main Apr 9, 2024
3 checks passed
@yuhao900914 yuhao900914 deleted the dependency branch April 9, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants