-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global user properties plugin #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there is a new CHANGELOG.md file, but the diff indicates it's empty.
Just a few comments and questions to address, otherwise LGTM.
packages/plugin-global-user-properties/src/global-user-properties.ts
Outdated
Show resolved
Hide resolved
@justin-fiedler should we point this pr to |
packages/plugin-global-user-properties/src/global-user-properties.ts
Outdated
Show resolved
Hide resolved
packages/plugin-global-user-properties/src/global-user-properties.ts
Outdated
Show resolved
Hide resolved
I think returning the event unmodified would work in these cases. I realize i meant to type as
The type narrowing is not what i'm expecting it to do, but ideally I'm only modifying events of type |
Thanks everyone for the comments (and sorry for the amount of copy-pasta I left on the ground). I've updated the readme and the tests to include a Unfortunately, ts-jest is having some issues picking up this file, so the tests use a couple of any's. I'll make this a follow up ticket if this isn't a blocker to this pr. |
@justin-fiedler @yuhao900914 I've limited my changes to the plugin package - I'll be merging this if there are no concerns |
Summary
This PR adds a simple enrichment plugin that transforms the user properties field into
global_user_properties
- a beta feature used internally firstChecklist